VS-1483 Update AoU documentation to include details for VAT delivery #8967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcovarr
reviewed
Aug 30, 2024
Comment on lines
108
to
112
| <li>kevin.levy@pmi-ops.org</li> | ||
| <li>srushti.gangireddy@pmi-ops.org</li> | ||
| <li>brian.freeman@pmi-ops.org </li> | ||
| <li>tarek.ahmed@pmi-ops.org</li> | ||
| <li>jennifer.zhang@pmi-ops.org</li> |
There was a problem hiding this comment.
do we really want to put these emails in our docs?
There was a problem hiding this comment.
Yeah - probably shouldn't but wasn't sure how to capture this level of detail.
There was a problem hiding this comment.
maybe link back to a Confluence or something?
There was a problem hiding this comment.
I've linked to a Google Doc that tracks what we did for Echo
| <li>jennifer.zhang@pmi-ops.org</li> | ||
| </ul> | ||
| - Copy the bgzipped, tarred export of the VAT into the pre-delivery bucket. For the Echo release, it was copied to `gs://prod-drc-broad/v8/wgs/vat/aou_srwgs_short_variants_v8r1.vat.bgz.tsv.gz` | ||
| - Finally, an email should be sent out notifying the AoU research workbench team (and others) of the readiness of the VAT. For echo, the email had the subject line: `Variant Annotations Table delivered for v8 srWGS joint callset` (it may just be easiest to find that email and modify it accordingly for the release you are working on.) |
There was a problem hiding this comment.
Suggested change
| - Finally, an email should be sent out notifying the AoU research workbench team (and others) of the readiness of the VAT. For echo, the email had the subject line: `Variant Annotations Table delivered for v8 srWGS joint callset` (it may just be easiest to find that email and modify it accordingly for the release you are working on.) | |
| - Finally, an email should be sent out notifying the AoU research workbench team (and others) of the readiness of the VAT. For echo, the email had the subject line: `Variant Annotations Table delivered for v8 srWGS joint callset` (it may just be easiest to find that email and modify it accordingly for the release you are working on). |
…dateAoUDocoForVATDelivery
…or the Echo callset.
mcovarr
reviewed
Sep 4, 2024
| Once the VAT table is created and a tsv is exported, the AoU research workbench team should be notified of its creation and permission should be granted so that several members of the team have view permission. | ||
|
|
||
| - Grant `BigQuery Data Viewer` permission to specific people's PMI-OPS accounts. This will include members of the AoU research workbench team. | ||
| - Copy the bgzipped, tarred export of the VAT into the pre-delivery bucket. |
There was a problem hiding this comment.
Is this gs://prod-drc-broad (confusingly also referred to in this same document as the "delivery bucket")? Also any suggested path for the VAT tarball or is that something for the Google Doc below?
There was a problem hiding this comment.
I've put that all in the linked Google Doc.
mcovarr
approved these changes
Sep 4, 2024
koncheto-broad
approved these changes
Sep 6, 2024
kbergin
reviewed
Sep 6, 2024
|
|
||
| - Grant `BigQuery Data Viewer` permission to specific people's PMI-OPS accounts. This will include members of the AoU research workbench team. | ||
| - Copy the bgzipped, tarred export of the VAT into the pre-delivery bucket. | ||
| - Send an email should be sent out notifying the AoU research workbench team of the readiness of the VAT. |
There was a problem hiding this comment.
Suggested change
| - Send an email should be sent out notifying the AoU research workbench team of the readiness of the VAT. | |
| - An email should be sent out notifying the AoU research workbench team and stakeholders of the readiness of the VAT. Additionally, a RW Jira ticket will be made by project management to request copying the VAT to pre-prod. |
…dateAoUDocoForVATDelivery
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.