Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

queryItems arg for custom func in ElasticsearchClient #27

Merged
merged 4 commits into from
Jun 11, 2024
Merged

queryItems arg for custom func in ElasticsearchClient #27

merged 4 commits into from
Jun 11, 2024

Conversation

leonidas-o
Copy link
Contributor

Option to submit queryItems to custom func, which will be handed over to the buildURL func

0xTim
0xTim requested changes May 13, 2024
View reviewed changes
Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any change you could add a test to ensure this is hooked up correctly? Thanks!

@leonidas-o
Copy link
Contributor Author

sure, test added

0xTim
0xTim approved these changes Jun 11, 2024
View reviewed changes
Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@0xTim 0xTim merged commit 0963ff3 into brokenhandsio:main Jun 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xTim 0xTim 0xTim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leonidas-o @0xTim