macos fixes and build script refactor

[nat3Github]

• hi there! thanks for the project
• i am using a macbook pro m1
• here are some fixes in the build to get the static build running for triangle test
• • when building statically link the Frameworks to the module
• • create the output folder if its deleted

Q: do you know if Framework "QuartzCore" is really required? triangle test works without it

note: depending on system installed macos frameworks makes the build non portable aka you can not cross compile from another platform.

[bronter]

Thanks for the PR! It's always great when I get feedback for platforms I can't personally test on.

As far as I can tell, QuartzCore is mostly used for animation and windowing, and since neither the triangle example nor any of the tests in this repository spawn a window, it probably isn't needed here.

I do have a couple issues, mostly around what happens when you run tests or build on linux. Let me know if you need help or clarification, or if you just disagree with my suggestions; I'm always open to trying things a new way. Thanks again!

[bronter]

On linux this causes the build to fail since it can't find the frameworks. I think it would also fail on mac if you were trying to run the compute tests since compute-c would also need the frameworks. At this point it might be better to move the mac-specific stuff out into its own case, like

switch (target_res.os.tag) { // above on line 132
    .windows => {
          // ... all the windows stuff like it is currently
    },
    .macos => {
           // all the mac-specific stuff, both for static and dynamic link modes
          link_mac_frameworks(wgpu_mod);
          link_mac_frameworks(wgpu_c_mod);
    },
    else => {
          // All the stuff for linux/FreeBSD/etc, both for static and dynamic link modes;
          // This would be pretty much like it was before, but without the "} else if (target_res.os.tag == .macos ..." branch
    }

[bronter]

Do the unit tests still pass on mac with this removed? They don't use the wgpu module, so if you remove them here the test step won't link against those frameworks.

[bronter]

A bit of a nitpick, but I kind of prefer this line the way it was before; if you don't have a particularly high-resolution monitor this line wraps (or goes off the screen) when you write it like this.

[bronter]

I prefer not to suppress all errors here; if this were to fail for some other reason than PathAlreadyExists, you'd see an error show up in write24BitBMP() instead and it makes tracing the actual source of the error a little more difficult. It seems that std.fs.Dir has a makePath() function that handles the case where the directory already exists, and returns any other type of error, so maybe you could do try std.fs.cwd().makePath("examples/output");

[nat3Github]

i will look into it, if i remember correctly the changes i did to the build where done that if you import the module in another zig project the right dependencies are linked in by default, i didnt check the other stuff, sloppy on my part, will do!

[nat3Github]

sooo... this was a long endeavor. i found the build script a little bit convoluted, thats why i flatened it as much as is could

• all zig build command now work on my machine (macbook), static and dynamic
• since dynamic linkage requires some sort of platform specific bundling / distribution this is left to the end user! only the right shared library is exposed with dependency.namedLazyPath("libwgpu_native")

please let me know if something does not work on your platform (windows / linux?) i can later check on my windows machine, unfortunately i dont have a linux system rn

[bronter]

Thanks! I appreciate all the hard work.
Tests are all passing on linux. I've got an additional test process for Windows that I usually do; since Windows has both MSVC and MinGW there are often toolchain issues that don't come up unless try to use this library in a separate project. I'll test that out later today, I don't boot into Windows often so every time I do there's always a bunch of updates and other stuff I have to deal with first.

[nat3Github]

I don't boot into Windows often so every time I do there's always a bunch of updates and other stuff I have to deal with first.

yes, i totally feel the pain! thanks for checking, btw i heard something about a bad windows update which compromises specific SSD's

[nat3Github]

pinging this because wgpu-native was updated and the PR is bitrotting...