Skip to content

Commit

Permalink
Cleanup bicepconfig (radius-project#8012)
Browse files Browse the repository at this point in the history
# Description

Some experimental features in the bicepconfig were consolidated in the
Bicep repo: Azure/bicep#14944. This PR removes
the unnecessary features.

## Type of change

<!--

Please select **one** of the following options that describes your
change and delete the others. Clearly identifying the type of change you
are making will help us review your PR faster, and is used in authoring
release notes.

If you are making a bug fix or functionality change to Radius and do not
have an associated issue link please create one now.

-->

- This pull request is a minor refactor, code cleanup, test improvement,
or other maintenance task and doesn't change the functionality of Radius
(issue link optional).

<!--

Please update the following to link the associated issue. This is
required for some kinds of changes (see above).

-->

Fixes: #issue_number

## Contributor checklist
Please verify that the PR meets the following requirements, where
applicable:

- [ ] An overview of proposed schema changes is included in a linked
GitHub issue.
- [ ] A design document PR is created in the [design-notes
repository](https://github.com/radius-project/design-notes/), if new
APIs are being introduced.
- [ ] If applicable, design document has been reviewed and approved by
Radius maintainers/approvers.
- [x] A PR for the [samples
repository](https://github.com/radius-project/samples) is created, if
existing samples are affected by the changes in this PR. PR:
radius-project/samples#1879
- [x] A PR for the [documentation
repository](https://github.com/radius-project/docs) is created, if the
changes in this PR affect the documentation or any user facing updates
are made. PR: radius-project/docs#1265
- [x] A PR for the [recipes
repository](https://github.com/radius-project/recipes) is created, if
existing recipes are affected by the changes in this PR. PR:
radius-project/recipes#80

Signed-off-by: sk593 <shruthikumar@microsoft.com>
  • Loading branch information
sk593 authored Oct 23, 2024
1 parent ab67487 commit dd86d60
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 18 deletions.
8 changes: 2 additions & 6 deletions .github/workflows/functional-test-cloud.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -392,9 +392,7 @@ jobs:
cat <<EOF > ./test/bicepconfig.json
{
"experimentalFeaturesEnabled": {
"extensibility": true,
"extensionRegistry": true,
"dynamicTypeLoading": true
"extensibility": true
},
"extensions": {
"radius": "br:${{ env.BICEP_TYPES_REGISTRY }}/test/radius:$RADIUS_VERSION",
Expand Down Expand Up @@ -696,9 +694,7 @@ jobs:
cat <<EOF > ./test/bicepconfig.json
{
"experimentalFeaturesEnabled": {
"extensibility": true,
"extensionRegistry": true,
"dynamicTypeLoading": true
"extensibility": true
},
"extensions": {
"radius": "br:${{ env.BICEP_TYPES_REGISTRY }}/test/radius:$RADIUS_VERSION",
Expand Down
4 changes: 1 addition & 3 deletions .github/workflows/functional-test-noncloud.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -338,9 +338,7 @@ jobs:
cat <<EOF > ./test/bicepconfig.json
{
"experimentalFeaturesEnabled": {
"extensibility": true,
"extensionRegistry": true,
"dynamicTypeLoading": true
"extensibility": true
},
"extensions": {
"radius": "br:${{ env.LOCAL_REGISTRY_SERVER }}:${{ env.LOCAL_REGISTRY_PORT }}/radius:$RADIUS_VERSION",
Expand Down
4 changes: 1 addition & 3 deletions bicepconfig.json
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
{
"experimentalFeaturesEnabled": {
"extensibility": true,
"extensionRegistry": true,
"dynamicTypeLoading": true
"extensibility": true
},
"extensions": {
"radius": "br:biceptypes.azurecr.io/radius:latest",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -85,9 +85,7 @@ Note: Alternatively, if you already have the Radius CLI installed, you can choos
```json
{
"experimentalFeaturesEnabled": {
"extensibility": true,
"extensionRegistry": true,
"dynamicTypeLoading": true
"extensibility": true
},
"extensions": {
"radius": "<file-path>",
Expand Down
4 changes: 1 addition & 3 deletions pkg/cli/setup/application.go
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,7 @@ resource demo 'Applications.Core/containers@2023-10-01-preview' = {

bicepConfigTemplate = `{
"experimentalFeaturesEnabled": {
"extensibility": true,
"extensionRegistry": true,
"dynamicTypeLoading": true
"extensibility": true
},
"extensions": {
"radius": "br:biceptypes.azurecr.io/radius:%s",
Expand Down

0 comments on commit dd86d60

Please sign in to comment.