Revamp CI, Enable it for 29.1, Fix flaky tests #551
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the mode detection consistent. Without this: Sometimes Emacs buffer used to use rustic mode and sometimes rust-ts-mode.
The source code is this:
fn main() {
let v = vec![1, 2, 3];
v[99];
}
While the code is incorrect, it does not have any compile error.
Fix possible babel test failures
Enable test for emacs 29.1
Update pinned rustc to latest stable
|
I would love to, but I wouldn't be able to review it given how unfamiliar I am with the project - I only know about my small contribution. |
|
Fair enough! I would like to avoid maintaining my own fork if possible, but I don't think it's possible anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changelog has more details.