disable undo keyboard shortcuts if in VScode mode #600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VScode has its own definition of undo/redo that send direct updates to the
TextDocumentbacking the editor.If CodeMirror also listens to these, then they fight a bit; for example, the
TextDocumentupdates, which tries to propagate its changes to the CodeMirror instance, which has just processed an undo, which then sends a message to update theTextDocument. This is especially bad for updates that undo to re-add text, because it can get interpreted as a double-insertion.So, let VScode be in charge of these events only, and respect the
TextDocumentas the model.