Code

Add support for units of measure#1454

Code

Open

BenMusch wants to merge 84 commits intobrownplt:horizonbrownplt/pyret-lang:horizonfrom BenMusch:units-of-measureBenMusch/pyret-lang:units-of-measureCopy head branch name to clipboard

+1,848-199

Commits

Commits on May 28, 2019

• Add grammar

  BenMusch

  committed
  f429a4d

  Copy full SHA for f429a4d

• Get a number syntax that parses

  BenMusch

  committed
  05b3a9c

  Copy full SHA for 05b3a9c

• Update AST, currently getting parse error

  BenMusch

  committed
  cb2f411

  Copy full SHA for cb2f411

Commits on May 29, 2019

• Update s-num matches to work (ignoring units)

  BenMusch

  committed
  2907a0e

  Copy full SHA for 2907a0e

• Add some labels/tosource

  BenMusch

  committed
  1988ae2

  Copy full SHA for 1988ae2

• Add parse tests

  BenMusch

  committed
  4c48e62

  Copy full SHA for 4c48e62

• Add wf-checks for units

  BenMusch

  committed
  e908e27

  Copy full SHA for e908e27

• Fix bugs, add well-formedness tests

  BenMusch

  committed
  e0da7e7

  Copy full SHA for e0da7e7

Commits on May 30, 2019

• Add units to a-num

  BenMusch

  committed
  8b1f148

  Copy full SHA for 8b1f148

• Add logic to normalize the units

  BenMusch

  committed
  a39fe86

  Copy full SHA for a39fe86

• WIP: Why won't this fail?

  BenMusch

  committed
  f8a0548

  Copy full SHA for f8a0548

Commits on May 31, 2019

• Some stuff is working, code needs cleanup and more thorough tests

  BenMusch

  committed
  25d0aa7

  Copy full SHA for 25d0aa7

• Remove a print

  BenMusch

  committed
  274d27f

  Copy full SHA for 274d27f

• Remove an is-operation that wasn't being used

  BenMusch

  committed
  1ad0ef8

  Copy full SHA for 1ad0ef8

Commits on Jun 1, 2019

• Delegate more responsibility to the Unitnums

  BenMusch

  committed
  0e9bc03

  Copy full SHA for 0e9bc03

• Fix a bug

  BenMusch

  committed
  6ce0ce0

  Copy full SHA for 6ce0ce0

Commits on Jun 3, 2019

• Add some basic tests, fix a bug

  BenMusch

  committed
  bdde186

  Copy full SHA for bdde186

• Fix grammar ambiguity, more tests

  BenMusch

  committed
  685c160

  Copy full SHA for 685c160

• WIP

  BenMusch

  committed
  0ea5f33

  Copy full SHA for 0ea5f33

• Unsupported operation tests

  BenMusch

  committed
  c81f57a

  Copy full SHA for c81f57a

• Add units to fracs, test some numeric operations

  BenMusch

  committed
  6efe7cb

  Copy full SHA for 6efe7cb

• Add some tests

  BenMusch

  committed
  27a7d00

  Copy full SHA for 27a7d00

• Add units to rfracs, fix bug, run all the tests

  BenMusch

  committed
  da92df1

  Copy full SHA for da92df1

• Fix a test

  BenMusch

  committed
  6aaa314

  Copy full SHA for 6aaa314

Commits on Jun 4, 2019

• Update grammar for predicates

  BenMusch

  committed
  1720bcc

  Copy full SHA for 1720bcc

• Add a-unit to Ann ast

  BenMusch

  committed
  0629341

  Copy full SHA for 0629341

• Add parsing tests

  BenMusch

  committed
  6ee5828

  Copy full SHA for 6ee5828

• Add wf-checks

  BenMusch

  committed
  bc08458

  Copy full SHA for bc08458

• Get rid of AUnits, normalize unit expressions at compile-time

  BenMusch

  committed
  e468a90

  Copy full SHA for e468a90

Commits on Jun 5, 2019

• Hack to default units to 1

  BenMusch

  committed
  ca760e6

  Copy full SHA for ca760e6

• Change from a runtime approach to a desugar approach

  BenMusch

  committed
  05fd792

  Copy full SHA for 05fd792

• Fix JS bug

  BenMusch

  committed
  927c4c3

  Copy full SHA for 927c4c3

• Add support for underscore annotations

  BenMusch

  committed
  4d478ab

  Copy full SHA for 4d478ab

• Tests for contracts

  BenMusch

  committed
  ca16198

  Copy full SHA for ca16198

• Add wf checks for underscores in units

  BenMusch

  committed
  020f04e

  Copy full SHA for 020f04e

• Enforce unit quantity and ordering via grammar, not wf

  BenMusch

  committed
  bf0689d

  Copy full SHA for bf0689d

Commits on Jun 6, 2019

• Switch numbers to always have a unit, start adding a visitor for units

  BenMusch

  committed
  43eada1

  Copy full SHA for 43eada1

• Refactor compile-unit to be faster

  BenMusch

  committed
  ff2434c

  Copy full SHA for ff2434c

• Refactor units to be visited

  BenMusch

  committed
  05384be

  Copy full SHA for 05384be

• Use fold-keys

  BenMusch

  committed
  7adc2f5

  Copy full SHA for 7adc2f5

• Sort units when making strings

  BenMusch

  committed
  5244510

  Copy full SHA for 5244510

• Refactor the grammar to resemble binops

  BenMusch

  committed
  b641650

  Copy full SHA for b641650

• Refactor unitnum handling in makeInteger*op() and throw errors on fractional operations

  BenMusch

  committed
  6f14aaa

  Copy full SHA for 6f14aaa

• Some housekeeping

  BenMusch

  committed
  e861205

  Copy full SHA for e861205

Commits on Jun 7, 2019

• Don't re-use mixed-binops

  BenMusch

  committed
  22e8088

  Copy full SHA for 22e8088

• Update annotations on num-* builtins

  BenMusch

  committed
  880c7ab

  Copy full SHA for 880c7ab

• Fix-up tests, now failing due to error messages. Need to test every num-* function, probably

  BenMusch

  committed
  9f1561f

  Copy full SHA for 9f1561f

• Test all num functions, fix some edge cases

  BenMusch

  committed
  ca86032

  Copy full SHA for ca86032

Commits on Jun 13, 2019

• Add withUnits pattern with some intermediate hacks and test failures

  BenMusch

  committed
  c9f8ea3

  Copy full SHA for c9f8ea3

Commits on Jun 14, 2019

• Slightly better errors

  BenMusch

  committed
  dcc35ea

  Copy full SHA for dcc35ea

• deploy

  BenMusch

  committed
  d470bd6

  Copy full SHA for d470bd6

• Some WIP

  BenMusch

  committed
  f1ae2b8

  Copy full SHA for f1ae2b8

Commits on Jun 15, 2019

• Add a test

  BenMusch

  committed
  535c6e7

  Copy full SHA for 535c6e7

• Fix-up render-fancy-reason for error

  BenMusch

  committed
  33339f6

  Copy full SHA for 33339f6

• Remove wf-check on powers

  BenMusch

  committed
  c45a0db

  Copy full SHA for c45a0db

• ???

  BenMusch

  committed
  ee8026f

  Copy full SHA for ee8026f

Commits on Jun 17, 2019

• Add support for 1 as a unit

  BenMusch

  committed
  bb56566

  Copy full SHA for bb56566

• sqrt/expt support for unitnums

  BenMusch

  committed
  32e84d1

  Copy full SHA for 32e84d1

• Add some more unit functions used by the UI

  BenMusch

  committed
  f917679

  Copy full SHA for f917679

• Always reset implicit on withUnit() calls

  BenMusch

  committed
  0217179

  Copy full SHA for 0217179

Commits on Jun 18, 2019

• Add test for un-implicit-ing a <1> annot

  BenMusch

  committed
  0ea223d

  Copy full SHA for 0ea223d

• Pyret error for incompatible units

  BenMusch

  committed
  7761c60

  Copy full SHA for 7761c60

• More pyret errors + better contract failures

  BenMusch

  committed
  b833d0c

  Copy full SHA for b833d0c

• Better tests for unit errors

  BenMusch

  committed
  9cb5c1c

  Copy full SHA for 9cb5c1c

• Dont support polymorphic 0, improve jsnums performance on units

  BenMusch

  committed
  1f40427

  Copy full SHA for 1f40427

• Reset pitometer files for now

  BenMusch

  committed
  ac3cb8b

  Copy full SHA for ac3cb8b

• Reset build dir

  BenMusch

  committed
  8fe17b2

  Copy full SHA for 8fe17b2

• Final pre-PR cleanup

  BenMusch

  committed
  c7a5dbd

  Copy full SHA for c7a5dbd

• Fix regression tests

  BenMusch

  committed
  56be3de

  Copy full SHA for 56be3de

Commits on Jun 19, 2019

• Use bigint when necessary on unit powers

  BenMusch

  committed
  84e2dec

  Copy full SHA for 84e2dec

• Fix division bug

  BenMusch

  committed
  e7cd223

  Copy full SHA for e7cd223

Commits on Jun 21, 2019

• Improve units-on-unsupport-ann message

  BenMusch

  committed
  780780e

  Copy full SHA for 780780e

• Improve incompatible-units error message

  BenMusch

  committed
  9701324

  Copy full SHA for 9701324

• Better invalid-unit-state messages

  BenMusch

  committed
  0a032ad

  Copy full SHA for 0a032ad

Commits on Jun 23, 2019

• Remove TODO in grammar

  BenMusch

  committed
  6d1de41

  Copy full SHA for 6d1de41

• Fix bug that drops srcloc on withUnit calls

  BenMusch

  committed
  e76f4d3

  Copy full SHA for e76f4d3

Commits on Jul 1, 2019

• Some progress, still need to test all error messages

  BenMusch

  committed
  7ddfc67

  Copy full SHA for 7ddfc67

Commits on Jul 8, 2019

• Remove error message TODOs

  BenMusch

  committed
  7854c19

  Copy full SHA for 7854c19

Commits on Jul 9, 2019

• Fix identical equality

  BenMusch

  committed
  75a1dc9

  Copy full SHA for 75a1dc9

Commits on Jul 15, 2019

• slight changes in error messages

  BenMusch

  committed
  4348552

  Copy full SHA for 4348552

Commits on Jul 16, 2019

• Fix equality bug

  BenMusch

  committed
  a788536

  Copy full SHA for a788536

• Fix bug in equal3 for within() checks on strings

  Show description for 7c66302
  BenMusch

  committed
  7c66302

  Copy full SHA for 7c66302

Commits on Jul 17, 2019

• Add tests for within() comparisons of strings, fix error message grammar

  BenMusch

  committed
  8637982

  Copy full SHA for 8637982

• Add comment explaining logic of equalHelp()

  BenMusch

  committed
  b849f93

  Copy full SHA for b849f93