Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fm/support iframes 3 #100

Closed
wants to merge 10 commits into from
Closed

Conversation

filip-michalsky
Copy link
Collaborator

why

We need to support i-frames

what changed

act() interface now loops through all eligible iframes if it cannot find the action in the main frame.

test plan

need more evals, example is passing.

@filip-michalsky
Copy link
Collaborator Author

@navidkpr can I get some feedback here pls, if I am on the right track, I will:

a) add multi-frame to extract() and observe()
b) add the eval to extract the filled out form

c) do we want to add wordle as its own 'playground' script? right now pnpm example runs the skin care inner i-frame fill in.

main philosophy here is to iterate through i-frames one by one if action/extraction cannot be completed, starting with the first one.

one big missing feature is extraction across multiple chunks vs completing after detecting something relevant in the first chunk.

filip-michalsky and others added 6 commits October 12, 2024 12:48
…ng for action if you can't find one and don't error right away (#102)

* Add errors in outputs of evals

* add retries to action

* cleanup
* improve action on flight ticket purchase

* cleanup
@filip-michalsky
Copy link
Collaborator Author

re-opened a new PR #100

@filip-michalsky filip-michalsky deleted the fm/support-iframes-3 branch October 25, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants