Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

js function declared as string #454

Merged
merged 1 commit into from
Feb 2, 2025
Merged

js function declared as string #454

merged 1 commit into from
Feb 2, 2025

Conversation

miguelg719
Copy link
Collaborator

why

error declaring js function as ts when resolving node path from a11y tree element

what changed

reverted function to string in js format

test plan

  • Deploy in vercel as package to confirm working

@miguelg719 miguelg719 requested a review from kamath February 2, 2025 07:01
@miguelg719 miguelg719 added the observe These changes pertain to the observe function label Feb 2, 2025
@miguelg719 miguelg719 marked this pull request as ready for review February 2, 2025 07:01
@kamath kamath merged commit 2855029 into main Feb 2, 2025
11 of 20 checks passed
@kamath kamath deleted the vercel_a11y_patch branch February 2, 2025 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamath kamath kamath approved these changes

Assignees
No one assigned
Labels
observe These changes pertain to the observe function
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miguelg719 @kamath