Merged
Conversation
Contributor
Greptile SummaryThis PR improves the agent package's GraphQL code generation setup by bundling the schema file, making it easier to run standalone and fixing TypeScript checks in CI. Key improvements:
The changes follow project conventions, use Bun correctly, and provide clear error messages. All modifications are well-documented in both the README and Confidence Score: 5/5
Important Files Changed
Last reviewed commit: 71dabc7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The agent project now bundles its own graphql schema file, making it easier to run standalone and also fixes the typescript checks in github actions.
This pull request updates the code generation workflow for the
apps/agentpackage, making it more robust and easier to configure. The main changes include improving the handling of the GraphQL schema path, updating documentation to clarify schema requirements, and adjusting the CI workflow to use the new codegen script.GraphQL code generation improvements:
The
codegen.tsscript now defaults to using the bundledschema/schema.graphqlifGRAPHQL_SCHEMA_PATHis not set, and throws a clear error if no schema is found. This makes local development and CI setup easier and more reliable.The
.env.examplefile now clarifies thatGRAPHQL_SCHEMA_PATHis optional and documents the fallback behavior.The
README.mdnow includes a new section explaining how codegen uses the schema, the default behavior, and how to override the schema path if needed.Continuous Integration workflow update:
.github/workflows/code-quality.yml) now runs the codegen step using the new script inapps/agent, replacing the previous agent SDK build step.