Skip to content

fix: typescript checks in ci#364

Merged
DaniAkash merged 4 commits intomainfrom
fix/typescript-checks-without-schema-file
Feb 26, 2026
Merged

fix: typescript checks in ci#364
DaniAkash merged 4 commits intomainfrom
fix/typescript-checks-without-schema-file

Conversation

@DaniAkash
Copy link
Contributor

The agent project now bundles its own graphql schema file, making it easier to run standalone and also fixes the typescript checks in github actions.

This pull request updates the code generation workflow for the apps/agent package, making it more robust and easier to configure. The main changes include improving the handling of the GraphQL schema path, updating documentation to clarify schema requirements, and adjusting the CI workflow to use the new codegen script.

GraphQL code generation improvements:

  • The codegen.ts script now defaults to using the bundled schema/schema.graphql if GRAPHQL_SCHEMA_PATH is not set, and throws a clear error if no schema is found. This makes local development and CI setup easier and more reliable.

  • The .env.example file now clarifies that GRAPHQL_SCHEMA_PATH is optional and documents the fallback behavior.

  • The README.md now includes a new section explaining how codegen uses the schema, the default behavior, and how to override the schema path if needed.

Continuous Integration workflow update:

  • The CI workflow (.github/workflows/code-quality.yml) now runs the codegen step using the new script in apps/agent, replacing the previous agent SDK build step.

@github-actions github-actions bot added the fix label Feb 26, 2026
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 26, 2026

Greptile Summary

This PR improves the agent package's GraphQL code generation setup by bundling the schema file, making it easier to run standalone and fixing TypeScript checks in CI.

Key improvements:

  • codegen.ts now uses a bundled schema/schema.graphql as fallback when GRAPHQL_SCHEMA_PATH is not set
  • CI workflow updated to run codegen directly instead of building the agent SDK package
  • Added NODE_OPTIONS with increased heap memory (4GB) to prevent OOM during TypeScript compilation
  • Documentation updated to clarify the optional nature of GRAPHQL_SCHEMA_PATH and explain fallback behavior

The changes follow project conventions, use Bun correctly, and provide clear error messages. All modifications are well-documented in both the README and .env.example.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • Score reflects well-structured changes that improve developer experience and CI reliability. The fallback logic is sound, error handling is clear, and all changes are properly documented. No bugs, security issues, or violations of project conventions were identified.
  • No files require special attention

Important Files Changed

Filename Overview
.github/workflows/code-quality.yml Updates CI to run codegen before typecheck, adds heap memory limit for TypeScript compilation
apps/agent/codegen.ts Implements fallback to bundled schema, validates schema existence with clear error message
apps/agent/schema/schema.graphql New bundled GraphQL schema file (1626 lines) enabling standalone codegen

Last reviewed commit: 71dabc7

@DaniAkash DaniAkash merged commit 5d082de into main Feb 26, 2026
6 of 7 checks passed
@DaniAkash DaniAkash deleted the fix/typescript-checks-without-schema-file branch February 26, 2026 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant