Skip to content

fix: resolve all bun audit vulnerabilities with package overrides #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DaniAkash wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: resolve all bun audit vulnerabilities with package overrides #338

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 22 additions & 16 deletions bun.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 11 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,5 +59,15 @@
"yarn": "please-use-bun",
"pnpm": "please-use-bun"
},
"packageManager": "bun@1.3.6"
"packageManager": "bun@1.3.6",
"overrides": {
"qs": "6.15.0",
"markdown-it": "14.1.1",
"lodash-es": "4.17.23",
"@modelcontextprotocol/sdk": "1.26.0",
"axios": "1.13.5",
"diff": "8.0.3",
Copy link
Contributor

@greptile-apps greptile-apps bot Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Major version override crosses semver boundary

The diff override forces version 8.0.3, but @google/gemini-cli-core declares "diff": "^7.0.0" as its dependency. This is a major version bump (7.x → 8.x) that crosses the declared semver range. Unlike the other overrides which are patch/minor bumps within compatible ranges, this one forces a version that @google/gemini-cli-core was not designed or tested against.

If diff@8 introduced breaking API changes (renamed exports, removed functions, changed signatures), this could cause runtime errors in @google/gemini-cli-core. Consider verifying that the gemini CLI core functionality still works correctly after this override, or check whether @google/gemini-cli-core has a newer version that declares compatibility with diff@8.

Prompt To Fix With AI 
This is a comment left during a code review.
Path: package.json
Line: 69:69

Comment:
**Major version override crosses semver boundary**

The `diff` override forces version `8.0.3`, but `@google/gemini-cli-core` declares `"diff": "^7.0.0"` as its dependency. This is a **major version bump** (7.x → 8.x) that crosses the declared semver range. Unlike the other overrides which are patch/minor bumps within compatible ranges, this one forces a version that `@google/gemini-cli-core` was not designed or tested against.

If `diff@8` introduced breaking API changes (renamed exports, removed functions, changed signatures), this could cause runtime errors in `@google/gemini-cli-core`. Consider verifying that the gemini CLI core functionality still works correctly after this override, or check whether `@google/gemini-cli-core` has a newer version that declares compatibility with `diff@8`.

How can I resolve this? If you propose a fix, please make it concise.

"@isaacs/brace-expansion": "5.0.1",
"hono": "4.11.9"
}
}
Loading