Merged
Conversation
…ts to fc_draw() and incorporate into fc_export()
fd8f9fa to
65f8dab
Compare
Contributor
Author
|
@pasahe I rebased the commits for this PR onto the current |
Collaborator
|
It works beautifully! I will add the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@pasahe While I was adding documentation, I noticed a bug with how the markdown text was not getting rendered properly. I fixed this in the DESCRIPTION file and then made some edits to the roxygen headers to maintain auto-links between packages (replacing the
\link{}calls with simple square brackets that achieve the same thing). The thing that made me notice the bug was that the bullet points were not rendering infc_export()details section the way they should have been before this fix.After that was fixed, then I committed the updates to
fc_draw()andfc_export()that were the primary concern for #43.Example:
Result:

Closes #43