-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve system storage and data structure #278
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need add - Compress images and redirect to /cubes after a successful import
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need optimization; restoring from a large text file, crashes the browser.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…ronous indexDB usage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional testing is required at the moment. Currently, no errors have been detected in the standard system after migrate from localStorage to indexDB. We can proceed to resume the import feature
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its needed allow users to edit the cube category from /cubes
since Cubedesk and CSTimer its not easy deduce the original category, and it could even be mixed. Will be the user's responsibility to make the necessary corrections.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current implementation is very slow and redundant writting and reading DB. The application experiences dropdowns in FPS that almost crash the browser when updating the selected cube statistics calculations after each solve and moving between pages.
It becomes notably slow, especially when there are more than 20,000 solves. (Big amount of data)
We can try removing unnecessary data pulls from the database (each read takes 2s), instead, maintain a updated copy in memory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
What does this PR do?
Related Issue(s)
#226
Screenshots or GIFs (if applicable)
![image](https://private-user-images.githubusercontent.com/119996547/296631899-83f11a65-9980-4646-a8ac-242b09979c14.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg4NzkwODcsIm5iZiI6MTczODg3ODc4NywicGF0aCI6Ii8xMTk5OTY1NDcvMjk2NjMxODk5LTgzZjExYTY1LTk5ODAtNDY0Ni1hOGFjLTI0MmIwOTk3OWMxNC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjA2JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIwNlQyMTUzMDdaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0xMTEwZTNlNjE2MzZjZWQ1MTA0ZDQzMDYyZWViOGViYjY4Mzc5OGFkMzQ4Y2M5NGJmMDNmZjFhYjE4ZjMzMWQ0JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.5VBCSd3uahr6yUo4ZdBVY3zBiAZvuKCQqkEakdm_eJo)
Importing status:
Checklist