Fix Windows system tray and add macOS ICNS icon support #1

Copilot · 2025-12-28T19:19:50Z

Windows system tray was displaying the generic application icon instead of the WoW Sync icon. The Win32 LoadImage() API with IMAGE_ICON type requires ICO format; attempting to load icon.png as an ICO fails silently and falls back to IDI_APPLICATION. Similarly, macOS benefits from ICNS format which supports multiple resolutions including retina (@2x) displays for crisp rendering at all sizes.

Changes

Windows Icon Support (ICO):

icons/generate_icons.py: Generate multi-resolution icon.ico (16x16 through 256x256) using Pillow's sizes parameter for proper DPI scaling
wow_sync/tray/tray_windows.py: Load icon.ico instead of icon.png
icons/icon.ico: Generated 68KB ICO file with 6 embedded resolutions

macOS Icon Support (ICNS):

icons/generate_icons.py: Generate multi-resolution icon.icns with retina support (16x16@2x through 512x512@2x) using icnsutil library
wow_sync/tray/tray_macos.py: Load icon.icns with PNG fallback for backward compatibility
icons/icon.icns: Generated 1MB ICNS file with standard macOS resolutions and retina support
requirements.txt: Added icnsutil as build dependency

Cross-Platform Build Support:

build.py: Use platform-specific icon formats (ICNS for macOS, ICO for Windows, PNG for Linux)

Before:

# Windows
icon_path = ICON_DIR / "icon.png"

# macOS
icon_path = ICON_DIR / "icon.png"

After:

# Windows - Use ICO file (supports multiple resolutions)
icon_path = ICON_DIR / "icon.ico"

# macOS - Use ICNS file (supports multiple resolutions and retina displays)
icon_path = ICON_DIR / "icon.icns"

Original prompt

On windows there is no icon in the system tray. the application is there but its just the default icon image

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: bryfur <7673964+bryfur@users.noreply.github.com>

bryfur · 2025-12-28T19:28:19Z

@copilot can you also then add support for the mac specific icon format?

Co-authored-by: bryfur <7673964+bryfur@users.noreply.github.com>

Copilot · 2025-12-28T19:36:20Z

@copilot can you also then add support for the mac specific icon format?

Added macOS ICNS icon support in commit 8a5cc30. The changes include:

Generated icon.icns with multiple resolutions including retina (@2x) support for 16x16 through 512x512
Updated tray_macos.py to use ICNS file with PNG fallback
Updated build.py to use ICNS for macOS executables
Added icnsutil as a build dependency

The ICNS file provides native macOS icon format with retina display support for crisp rendering at all sizes in the menu bar.

Copilot

Pull request overview

This PR fixes the Windows system tray icon issue where the default Windows icon was displayed instead of the custom WoW Sync icon. The root cause was that the Windows Win32 API's LoadImage() function with IMAGE_ICON type requires an ICO format file, but the code was attempting to load a PNG file. The fix implements proper multi-resolution ICO file generation for Windows and ICNS file generation for macOS.

Key changes:

Generated multi-resolution ICO file (16x16 through 256x256) for Windows system tray compatibility
Generated multi-resolution ICNS file with retina support for macOS menu bar icons
Updated platform-specific tray implementations to use the appropriate icon formats

Reviewed changes

Copilot reviewed 4 out of 7 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
wow_sync/tray/tray_windows.py	Changed icon path from PNG to ICO format for Windows tray implementation
wow_sync/tray/tray_macos.py	Added ICNS file support with PNG fallback for macOS menu bar icons
icons/generate_icons.py	Enhanced icon generation script to create multi-resolution ICO and ICNS files using Pillow and icnsutil
build.py	Updated PyInstaller build script to use platform-specific icon formats (ICNS for macOS, ICO for Windows)
requirements.txt	Added icnsutil library as optional build dependency for ICNS generation
icons/icon.ico	Generated binary ICO file containing multiple resolutions (16x16, 32x32, 48x48, 64x64, 128x128, 256x256)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-28T19:37:50Z

icons/generate_icons.py


-    for filename, size in sizes.items():
+    # Process all icon sizes and save as PNG files
+    icon_sizes_for_ico = {}


The data structure change from dictionary to list is good for maintaining order, but the variable name icon_sizes_for_ico is misleading. This dictionary is used to collect resized images for both ICO and ICNS file generation, not just ICO. Consider renaming it to icon_sizes_cache or resized_icons for better clarity.

Copilot · 2025-12-28T19:37:50Z

icons/generate_icons.py

        resized.save(output_path, "PNG", optimize=True)
        print(f"  ✓ Saved {output_path}")
+
+        # Collect images for ICO file (avoid duplicates)


The comment states "avoid duplicates" but the logic actually ensures only one image per size is stored, using the last one processed. If the sizes list has duplicates (like two entries with size 256), the second will overwrite the first. Consider either removing duplicates from the sizes list earlier, or clarifying the comment to explain this overwrite behavior.

Suggested change

# Collect images for ICO file (avoid duplicates)

# Track unique icon sizes for the ICO file (skip duplicate sizes in the sizes list)

Copilot · 2025-12-28T19:37:50Z

icons/generate_icons.py

+
+            temp_png = icons_dir / f"icon_{normal_size}x{normal_size}.png"
+            img.save(temp_png, "PNG")
+            icns.add_media(file=str(temp_png))
+            temp_png.unlink()
+
+            # Add retina resolution
+            if retina_size in icon_sizes_for_ico:
+                retina_img = icon_sizes_for_ico[retina_size]
+            elif retina_size <= 1024:
+                retina_img = transparent_img.resize((retina_size, retina_size), Image.Resampling.LANCZOS)
+            else:
+                # For 1024, just use the processed image
+                retina_img = transparent_img.resize((1024, 1024), Image.Resampling.LANCZOS)
+
+            temp_retina_png = icons_dir / f"icon_{normal_size}x{normal_size}@2x.png"
+            retina_img.save(temp_retina_png, "PNG")
+            icns.add_media(file=str(temp_retina_png))


The temporary PNG files created for ICNS generation are immediately deleted after being added to the ICNS file. However, if an exception occurs between saving the temp file and unlinking it (e.g., in the icns.add_media() call), the temp file will not be cleaned up. Consider using a try-finally block or context manager to ensure cleanup, or use a temporary directory that's automatically cleaned up.

Copilot · 2025-12-28T19:37:50Z

wow_sync/tray/tray_windows.py

    async def setup(self):
        """Setup the tray icon using Windows Shell NotifyIcon."""
-        icon_path = ICON_DIR / "icon.png"
+        # Use ICO file for Windows (supports multiple resolutions)


The comment "Use ICO file for Windows (supports multiple resolutions)" is helpful, but it would be even more informative to mention that PNG files cannot be loaded as ICO files using the Win32 API's LoadImage function, which was the root cause of the bug being fixed.

Suggested change

# Use ICO file for Windows (supports multiple resolutions)

# Use ICO file for Windows: LoadImage cannot load PNG files as ICOs,

# and this limitation previously caused a bug when using a PNG icon.

Copilot · 2025-12-28T19:37:51Z

build.py

    '--onedir' if sys.platform == 'darwin' else '--onefile',
    '--noconsole',
-    '--icon=icons/icon.png',
+    '--icon=icons/icon.icns' if sys.platform == 'darwin' else ('--icon=icons/icon.ico' if sys.platform == 'win32' else '--icon=icons/icon.png'),


The build script has a complex ternary expression that's difficult to read and maintain. Consider breaking this into multiple lines or using if-elif-else logic for better readability. For example:

if sys.platform == 'darwin': icon_arg = '--icon=icons/icon.icns' elif sys.platform == 'win32': icon_arg = '--icon=icons/icon.ico' else: icon_arg = '--icon=icons/icon.png'

Then use icon_arg in the list.

Copilot AI assigned Copilot and bryfur Dec 28, 2025

Initial plan

94aa8bd

Copilot started work on behalf of bryfur December 28, 2025 19:20 View session

Copilot AI and others added 3 commits December 28, 2025 19:22

Generate and use ICO file for Windows system tray icon

5836f4f

Co-authored-by: bryfur <7673964+bryfur@users.noreply.github.com>

Improve ICO file generation to properly use resized images

f11a457

Co-authored-by: bryfur <7673964+bryfur@users.noreply.github.com>

Improve code comments for clarity

6ffb231

Co-authored-by: bryfur <7673964+bryfur@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Fix missing application icon in system tray on Windows~~ Fix Windows system tray showing default icon instead of custom icon Dec 28, 2025

Copilot AI requested a review from bryfur December 28, 2025 19:27

Copilot finished work on behalf of bryfur December 28, 2025 19:27

Copilot started work on behalf of bryfur December 28, 2025 19:28 View session

Add macOS ICNS icon support for native menu bar icons

8a5cc30

Co-authored-by: bryfur <7673964+bryfur@users.noreply.github.com>

bryfur marked this pull request as ready for review December 28, 2025 19:35

Copilot AI review requested due to automatic review settings December 28, 2025 19:35

Copilot started reviewing on behalf of bryfur December 28, 2025 19:35 View session

Update ICNS mappings with explanatory comment

32769d3

Co-authored-by: bryfur <7673964+bryfur@users.noreply.github.com>

Copilot AI changed the title ~~Fix Windows system tray showing default icon instead of custom icon~~ Fix Windows system tray and add macOS ICNS icon support Dec 28, 2025

Copilot finished work on behalf of bryfur December 28, 2025 19:37

Copilot AI reviewed Dec 28, 2025

View reviewed changes

bryfur merged commit 26af321 into master Dec 28, 2025
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix Windows system tray and add macOS ICNS icon support #1

Fix Windows system tray and add macOS ICNS icon support #1

Uh oh!

Copilot AI commented Dec 28, 2025 •

edited

Loading

Uh oh!

bryfur commented Dec 28, 2025

Uh oh!

Copilot AI commented Dec 28, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Dec 28, 2025

Uh oh!

Copilot AI Dec 28, 2025

Uh oh!

Copilot AI Dec 28, 2025

Uh oh!

Copilot AI Dec 28, 2025

Uh oh!

Copilot AI Dec 28, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	# Collect images for ICO file (avoid duplicates)
	# Track unique icon sizes for the ICO file (skip duplicate sizes in the sizes list)

	# Use ICO file for Windows (supports multiple resolutions)
	# Use ICO file for Windows: LoadImage cannot load PNG files as ICOs,
	# and this limitation previously caused a bug when using a PNG icon.

Fix Windows system tray and add macOS ICNS icon support #1

Fix Windows system tray and add macOS ICNS icon support #1

Uh oh!

Conversation

Copilot AI commented Dec 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Uh oh!

bryfur commented Dec 28, 2025

Uh oh!

Copilot AI commented Dec 28, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Dec 28, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 28, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 28, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 28, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 28, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Dec 28, 2025 •

edited

Loading