Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 1, 2026

Adds separate build artifacts for macOS Intel (x86_64) and Apple Silicon (ARM64) architectures.

Changes

  • Build matrix: Added macos-15 (Intel) alongside macos-latest (ARM), using explicit matrix configuration with architecture-specific artifact names
  • Artifacts: Renamed WoWSync-macOS.zipWoWSync-macOS-ARM.zip, added WoWSync-macOS-Intel.zip
  • Releases: Both macOS builds now included in tagged releases
  • Documentation: Updated README-BUILD.md to note dual-architecture builds

Build Matrix

- os: macos-15           # Intel
  artifact-name: WoWSync-macOS-Intel
- os: macos-latest       # ARM
  artifact-name: WoWSync-macOS-ARM

Users on Intel Macs can now download native builds instead of running ARM binaries under Rosetta.

Original prompt

Make a build for macos intel


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI self-assigned this Jan 1, 2026
Copilot AI and others added 2 commits January 1, 2026 20:52
Co-authored-by: bryfur <7673964+bryfur@users.noreply.github.com>
Co-authored-by: bryfur <7673964+bryfur@users.noreply.github.com>
Copilot AI changed the title [WIP] Add build process for macOS Intel Add macOS Intel build support Jan 1, 2026
Copilot AI requested a review from bryfur January 1, 2026 20:55
@bryfur
Copy link
Owner

bryfur commented Jan 1, 2026

@copilot
The macOS-13 based runner images are being deprecated, consider switching to macOS-15 (macos-15-intel) or macOS 15 arm64 (macos-latest) instead. For more details see actions/runner-images#13046

Co-authored-by: bryfur <7673964+bryfur@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Jan 1, 2026

@copilot
The macOS-13 based runner images are being deprecated, consider switching to macOS-15 (macos-15-intel) or macOS 15 arm64 (macos-latest) instead. For more details see https://github.com/acti...

Updated to use macos-15-large runner in commit 335e9b8.

@bryfur
Copy link
Owner

bryfur commented Jan 1, 2026

@copilot why large, and not just macos-15-intel

Co-authored-by: bryfur <7673964+bryfur@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Jan 1, 2026

@copilot why large, and not just macos-15-intel

You're right. Changed to macos-15 in commit 324f4d2. The -large suffix refers to instance size, not architecture. macos-15 is the standard Intel runner label.

@bryfur bryfur marked this pull request as ready for review January 1, 2026 21:11
Copilot AI review requested due to automatic review settings January 1, 2026 21:11
@bryfur bryfur merged commit 11f067d into master Jan 1, 2026
5 checks passed
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for building separate macOS executables for Intel (x86_64) and Apple Silicon (ARM64) architectures, allowing Intel Mac users to download native builds instead of relying on Rosetta emulation.

Key Changes:

  • Converted build matrix from simple list to explicit include-based configuration with architecture-specific artifact naming
  • Split macOS build into two separate jobs: one for Intel and one for ARM
  • Updated release workflow to upload both macOS architecture variants

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
.github/workflows/build.yml Restructured build matrix to create separate Intel and ARM macOS builds with architecture-specific artifact names; updated release to include both variants
README-BUILD.md Added note documenting dual-architecture macOS builds in GitHub Actions

Critical Issue Found: The PR uses an invalid GitHub runner label macos-15-intel which does not exist. GitHub's macos-15 runners are Apple Silicon (ARM64), while Intel runners are macos-13 or macos-13-large. This will cause the workflow to fail.

python-version: '3.13'
artifact-name: WoWSync-Linux
archive-name: WoWSync-Linux.tar.gz
- os: macos-15-intel
Copy link

Copilot AI Jan 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The runner label macos-15-intel is not a valid GitHub-hosted runner. According to GitHub's documentation, macos-15 runs on Apple Silicon (ARM64), not Intel. For Intel (x86_64) builds, you should use macos-13 or macos-13-large which run on Intel hardware. Consider changing this to macos-13 for Intel support.

Suggested change
- os: macos-15-intel
- os: macos-13

Copilot uses AI. Check for mistakes.
- Or: `dist/WoWSync` (single executable)
- May need to sign the app for distribution
- Create DMG with: `hdiutil create -volname "WoW Sync" -srcfolder dist/WoWSync.app -ov -format UDZO WoWSync.dmg`
- **Note**: GitHub Actions builds create separate artifacts for Intel (macOS 15) and Apple Silicon (ARM) architectures
Copy link

Copilot AI Jan 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation states "Intel (macOS 15)" but macOS 15 runners are Apple Silicon, not Intel. This should be corrected to reference the actual Intel runner being used (e.g., "Intel (macOS 13)").

Suggested change
- **Note**: GitHub Actions builds create separate artifacts for Intel (macOS 15) and Apple Silicon (ARM) architectures
- **Note**: GitHub Actions builds create separate artifacts for Intel (macOS 13) and Apple Silicon (ARM) architectures

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants