-
Notifications
You must be signed in to change notification settings - Fork 0
Add macOS Intel build support #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
b60aec2
Initial plan
Copilot 7197587
Add macOS Intel build support to GitHub Actions workflow
Copilot 024f6b9
Update README-BUILD.md to document macOS architecture builds
Copilot 335e9b8
Update to macos-15-large runner to avoid deprecation
Copilot 324f4d2
Use macos-15 runner instead of macos-15-large for Intel builds
Copilot 37a2f9f
Update macOS job to use macos-15-intel
bryfur File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -46,6 +46,7 @@ pyinstaller --name=WoWSync \ | |||||
| - Or: `dist/WoWSync` (single executable) | ||||||
| - May need to sign the app for distribution | ||||||
| - Create DMG with: `hdiutil create -volname "WoW Sync" -srcfolder dist/WoWSync.app -ov -format UDZO WoWSync.dmg` | ||||||
| - **Note**: GitHub Actions builds create separate artifacts for Intel (macOS 15) and Apple Silicon (ARM) architectures | ||||||
|
||||||
| - **Note**: GitHub Actions builds create separate artifacts for Intel (macOS 15) and Apple Silicon (ARM) architectures | |
| - **Note**: GitHub Actions builds create separate artifacts for Intel (macOS 13) and Apple Silicon (ARM) architectures |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The runner label
macos-15-intelis not a valid GitHub-hosted runner. According to GitHub's documentation,macos-15runs on Apple Silicon (ARM64), not Intel. For Intel (x86_64) builds, you should usemacos-13ormacos-13-largewhich run on Intel hardware. Consider changing this tomacos-13for Intel support.