-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate path optimization of disconnected components in the network graph #53
Open
Todorbsc
wants to merge
8
commits into
master
Choose a base branch
from
fix/issue51_separe_disconn_graphs_opt
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
474427d
Implement function to find path disconnected components
Todorbsc 4484f5d
Fix einexpr function to respect Optimizers abstract class method
Todorbsc 0700b48
Separate optimization for each disconnected components in path
Todorbsc ba187ec
Merge branch 'master' into fix/issue51_separe_disconn_graphs_opt
Todorbsc 95af947
Fix code style
Todorbsc 4a1993c
Fix code style
Todorbsc 2fc3371
Fix code style
Todorbsc 48f18fc
Replace dfs function by connected_components from Graphs package
Todorbsc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -27,7 +27,7 @@ The implementation uses a binary heaptree to sort candidate pairwise tensor cont | |
outer::Bool = false | ||
end | ||
|
||
function einexpr(config::Greedy, path::EinExpr{L}, sizedict::Dict{L}) where {L} | ||
function einexpr(config::Greedy, sizedict::Dict{L}, path::EinExpr{L}) where {L} | ||
# remove self-loops | ||
path = sumtraces(path) | ||
metric = config.metric(sizedict) | ||
|
@@ -70,4 +70,4 @@ function einexpr(config::Greedy, path::EinExpr{L}, sizedict::Dict{L}) where {L} | |
return path | ||
end | ||
|
||
einexpr(config::Greedy, path::SizedEinExpr) = SizedEinExpr(einexpr(config, path.path, path.size), path.size) | ||
einexpr(config::Greedy, path::SizedEinExpr) = SizedEinExpr(einexpr(config, path.size, path.path), path.size) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same as above: why change the order? |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why change the order?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because of the multiple dispatching: this way, all optimizers'
einexpr
function are called throughOptimizers.einexpr
when the function call is like the one suggested in the issue #51:Although I am not really convinced about this fix, it makes possible to call the optimizers with each of the non-interconnected subgraphs at the level of abstraction of the class
Optimizers
avoiding the need to modify each specific optimizer.Let me know what are your thoughts on this and whether there's another more-suitable way to implement this.