Skip to content

#360250: add pin element #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Mar 6, 2025
Merged

#360250: add pin element #104

merged 15 commits into from
Mar 6, 2025

Conversation

Sophiaw-hub
Copy link
Contributor

@Sophiaw-hub Sophiaw-hub commented Apr 15, 2024

  • Das Pin-Element befindet sich bereits in einem Formular und muss nicht extra in eins gezogen werden. Denn der Use Case benötigt in der Regel für die Pin-Eingabe nur das zugehörige Element und ggf. noch ein Textfeld.
  • Bei der Eingabe werden nur Zahlen zugelassen.
  • Es wird validiert, ob das Element befüllt ist.
  • Über Style Configs kann eingestellt werden, ob das Formular automatisch abgeschickt werden soll.
  • Über Style Configs kann eingestellt werden, ob die Pin-Elemente mit einer Nummer gelabelt werden sollen.

@Sophiaw-hub Sophiaw-hub requested review from innerjoin and derB4 April 15, 2024 08:48
@Sophiaw-hub Sophiaw-hub self-assigned this Apr 15, 2024
@Sophiaw-hub Sophiaw-hub force-pushed the features/swl/pin-element branch from b2eba80 to 7c350a2 Compare April 18, 2024 13:28
Copy link
Contributor

@derB4 derB4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sieht insgesamt schon sehr gut aus, aber ich hab immer was zu meckern

@Sophiaw-hub Sophiaw-hub changed the title add pin element plus container add pin element Apr 29, 2024
@Sophiaw-hub Sophiaw-hub force-pushed the features/swl/pin-element branch from 1dc8df5 to 97ee5e9 Compare April 29, 2024 15:26
@Sophiaw-hub Sophiaw-hub requested a review from derB4 April 29, 2024 15:27
@innerjoin innerjoin changed the title add pin element #360250: add pin element May 16, 2024
@Sophiaw-hub Sophiaw-hub closed this Oct 8, 2024
@Sophiaw-hub Sophiaw-hub reopened this Oct 8, 2024
@Sophiaw-hub Sophiaw-hub removed the request for review from innerjoin November 6, 2024 13:52
@LukasBSI
Copy link
Contributor

LukasBSI commented Dec 2, 2024

@Sophiaw-hub magst du noch das Changelog updaten? :)

@LukasBSI LukasBSI force-pushed the features/swl/pin-element branch from 1ff3eb3 to 58ea3f5 Compare February 18, 2025 15:32
@LukasBSI
Copy link
Contributor

@derB4 der MR ist bereits ordentlich getestet und Code ist optimiert.
Bin ready fürs Review :)

Copy link
Contributor

@derB4 derB4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nur "Gemecker", kann aus meiner Sicht so gemergt werden

Co-authored-by: derB4 <122090401+derB4@users.noreply.github.com>
@LukasBSI LukasBSI merged commit 05c31d6 into main Mar 6, 2025
@LukasBSI LukasBSI deleted the features/swl/pin-element branch March 6, 2025 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants