feat(save): Whitelist sameSite as a cookie attribute
#9
+3
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sevagsim
force-pushed
the
feat/whitelist-samesite-attribute
branch
from
6753a5a to
b56c010
Compare
sevagsim
force-pushed
the
feat/whitelist-samesite-attribute
branch
from
b56c010 to
b55f99f
Compare
Owner
|
thanks for the PR @sevagsim, I'll be able to take a closer look and get this released soon |
Author
|
@bsidelinger912 Thank you @bsidelinger912 - we had to fork this repo and make the update due to our site breaking because Google Chrome updating to samesite Lax cookies by default. We would prefer to not use a forked version, so the sooner we can merge this and get a release, the better. Greatly appreciated! |
|
any reason this isn't merged? |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.