Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dependencies, handle profile links. #3

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

alirobe
Copy link

@alirobe alirobe commented Dec 5, 2024

Hi,

I'm proposing some minor changes.

  1. I updated the packages.json file to latest working versions. (note: the largest chunk size did increase from 700kb to 1mb, due to upstream additions to the bluesky API package, I've +1'd the issue Request for ES Module Support in @atproto/api bluesky-social/atproto#2175 about the problem)
  2. I corrected the links to profile pages for users on *.bsky.social, previously it was stripping out that part of the profile URL, resulting in broken links.
  3. I changed the loading text from 'loading your {collection}' to 'loading {collection}', as you could be looking at any profile. :)

@alirobe
Copy link
Author

alirobe commented Dec 5, 2024

Just seen a dupe PR here - #2

Didn't realise that was being worked on elsewhere :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant