Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hk/bump deps 2023 10 18 #65

Merged
merged 3 commits into from
Oct 23, 2023
Merged

Hk/bump deps 2023 10 18 #65

merged 3 commits into from
Oct 23, 2023

Conversation

andyborn
Copy link
Contributor

@andyborn andyborn commented Oct 18, 2023 •
edited
Loading

auto dependabot CI tests fail due to credentials not being injected so doing same bumps here

@andyborn andyborn requested a review from dim October 18, 2023 13:52
@dim
Copy link
Member

dim commented Oct 23, 2023

One test is still failing

@andyborn
Copy link
Contributor Author

One test is still failing

Cant figure this one out... says its failing on lint for bfsgs. I'm running the same version of golangci-lint locally (1.55.0) and it passes fine.

@dim
Copy link
Member

dim commented Oct 23, 2023

In bfsgs, delete go.sum, remove all deps from go.mod and run go mod tidy, then try again

@dim dim merged commit e1992a6 into main Oct 23, 2023
19 of 20 checks passed
@dim dim deleted the hk/bump-deps-2023-10-18 branch October 23, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dim dim Awaiting requested review from dim

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andyborn @dim