Added ability to set instrument_nr and set instrument name based on G… #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…M instr no. I didn't seem to be possible to set instrument_nr. It was hardcoded as 1 and setting it as per docs didn't work. Also the list of instrument names didn't seem to be utilized so I propose changing the constructor argument from name to instrument_nr and then the name is being auto-set based on id using the GM list. Not really sure how to handle out of range numbers here (are they allowed by midi standard ect) so just setting 'Unknown Instrument' as name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…M instr no.
I didn't seem to be possible to set instrument_nr. It was hardcoded as 1 and setting it as per docs didn't work. Also the list of instrument names didn't seem to be utilized so I propose changing the constructor argument from name to instrument_nr and then the name is being auto-set based on id using the GM list. Not really sure how to handle out of range numbers here (are they allowed by midi standard ect) so just setting 'Unknown Instrument' as name