Skip to content

Add missing entries for '7sus4', 'add11', 'add13', 'add9' to chord_shorthand #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add missing entries for '7sus4', 'add11', 'add13', 'add9' to chord_shorthand #88

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f369ce5
Add numpy to requirements-dev.in, tests don't run without it.
yaph Dec 17, 2021
9f6e1cc
Add missing entries for '7sus4', 'add11', 'add13', 'add9' to chord_sh…
yaph Dec 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions mingus/core/chords.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1328,8 +1328,8 @@ def determine_polychords(chord, shorthand=False):
return polychords


# A dictionairy that can be used to present chord abbreviations. This
# dictionairy is also used in from_shorthand()
# A dictionary that can be used to present chord abbreviations. This
# dictionary is also used in from_shorthand()
chord_shorthand = { # Triads Augmented chords Suspended chords Sevenths Sixths
# Ninths Elevenths Thirteenths Altered Chords Special
"m": minor_triad,
Expand All @@ -1344,10 +1344,12 @@ def determine_polychords(chord, shorthand=False):
"m7+": augmented_minor_seventh,
"7+": augmented_major_seventh,
"sus47": suspended_seventh,
"7sus4": suspended_seventh,
"sus4": suspended_fourth_triad,
"sus2": suspended_second_triad,
"sus": suspended_triad,
"11": eleventh,
"add11": eleventh,
"sus4b9": suspended_fourth_ninth,
"susb9": suspended_fourth_ninth,
"m7": minor_seventh,
Expand All @@ -1366,6 +1368,7 @@ def determine_polychords(chord, shorthand=False):
"6/9": sixth_ninth,
"69": sixth_ninth,
"9": dominant_ninth,
"add9": dominant_ninth,
"7b9": dominant_flat_ninth,
"7#9": dominant_sharp_ninth,
"M9": major_ninth,
Expand All @@ -1375,6 +1378,7 @@ def determine_polychords(chord, shorthand=False):
"M13": major_thirteenth,
"m13": minor_thirteenth,
"13": dominant_thirteenth,
"add13": dominant_thirteenth,
"7b5": dominant_flat_five,
"hendrix": hendrix_chord,
"7b12": hendrix_chord,
Expand Down
1 change: 1 addition & 0 deletions requirements-dev.in
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
black
numpy
twine
wheel