Skip to content

Conversation

@cwurld
Copy link

@cwurld cwurld commented Feb 5, 2022

…s were played with the instrument in track 1.

Fixed bug that caused note outside of track one to never stop. All stop commands were being sent to channel 1.

Added an example that was affected by these bugs and now plays correctly.

Chuck Martin added 4 commits February 5, 2022 08:07
…s were played with the instrument in track 1.

Fixed bug that caused note outside of track one to never stop. All stop commands were being sent to channel 1.

Added an example that was affected by these bugs and now plays correctly.
…in milliseconds and list of events as values.

Added percussion class.

Updated multiple_instruments.py demo to include percussion.

Fixed Note to properly play velocity.
@yansnow78
Copy link

yansnow78 commented Mar 22, 2022

there is he same bug with property velocity. I don't understand how this bug can be there since 2 years without any correction

an other way to fix it is to replace the following line in Sequencer.play_Note(...) #96

    if hasattr(note, "velocity"):
        velocity = note.velocity
    if hasattr(note, "channel"):
        channel = note.channel

by

    if "velocity" in note.__dict__:
        velocity = note.velocity
    if "channel" in note.__dict__:
        channel = note.channel

Chuck Martin added 7 commits April 10, 2022 14:07
More updates to keyboard_drumset.py.
…ating player to keep the synth running between changes to code that generates tracks. This is helpful because it takes more than 5 seconds to initialize the synth on my Macbook Pro.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants