Accounting for asDict, asCrossSection in MieQ()#10
Open
wlwatkins wants to merge 2 commits intobsumlin:masterfrom
Open
Accounting for asDict, asCrossSection in MieQ()#10wlwatkins wants to merge 2 commits intobsumlin:masterfrom
wlwatkins wants to merge 2 commits intobsumlin:masterfrom
Conversation
added 2 commits
January 6, 2019 01:10
When the core shell system sent by the user is actually a single homogenous particle, MieQCoreShell() triggers MieQ() though without keeping the user's choice regarding asDict, asCrossSection which and set to False by default., These were thus added to the MieQ() so that it doesn't throw an error if the dict expected to be returned by MieQ when implemented receives a tuple.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the core shell system sent by the user is actually a single homogenous particle, MieQCoreShell() triggers MieQ() though without keeping the user's choice regarding asDict, asCrossSection which and set to False by default.,
These were thus added to the MieQ() so that it doesn't throw an error if the dict expected to be returned by MieQ when implemented receives a tuple.