Test branch #10
Draft
Test branch #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tracks, Monitor not implemented?
Implemented JSON-RPC server with Django
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| response_data = server.handle_json_rpc_request(request_data) | ||
|
|
||
| # Return JSON response | ||
| return JsonResponse(response_data, status=200) |
Check warning
Code scanning / CodeQL
Information exposure through an exception Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 2 days ago
The best way to fix the problem is to ensure that error messages sent to clients are generic and do not contain exception-derived details.
- In
src/bsv_wallet_toolbox/rpc/json_rpc_server.py:- In all relevant
except Exception as e:blocks and similar, update the returned error object so that the"message"field uses a hardcoded, generic string instead ofstr(e)orf"Internal error: {e!s}". - Log the actual details server-side, but always return either
"Internal error"for unexpected exceptions, or use the protocol-specified generic messages for known exception types.
- In all relevant
- In
examples/django_server/wallet_app/views.py:- No change is needed, as this endpoint already returns the result from the RPC server, and the actual leak occurs upstream (in the RPC error construction).
The detailed change:
- For all three error-generating blocks in
src/bsv_wallet_toolbox/rpc/json_rpc_server.py, change:JsonRpcInternalError(str(e)).to_dict()→JsonRpcInternalError().to_dict()JsonRpcInternalError(f"Internal error: {e!s}").to_dict()→JsonRpcInternalError().to_dict()- Similarly for parameter errors: optionally, sanitize the error message for
JsonRpcInvalidParamsError, but if further sanitization is desired, make even this message generic, e.g. "Invalid parameters" instead of includinge!s.
No additional imports or method definitions are needed.
Suggested changeset
1
src/bsv_wallet_toolbox/rpc/json_rpc_server.py
Outside changed files
| @@ -469,10 +469,10 @@ | ||
| } | ||
|
|
||
| except Exception as e: | ||
| logger.error(f"Unexpected error during request validation: {e}") | ||
| logger.error(f"Unexpected error during request validation: {e}", exc_info=True) | ||
| return { | ||
| "jsonrpc": "2.0", | ||
| "error": JsonRpcInternalError(str(e)).to_dict(), | ||
| "error": JsonRpcInternalError().to_dict(), | ||
| "id": request_id, | ||
| } | ||
|
|
||
| @@ -516,7 +514,7 @@ | ||
| logger.warning(f"Invalid params for method {method}: {e}") | ||
| return { | ||
| "jsonrpc": "2.0", | ||
| "error": JsonRpcInvalidParamsError(f"Invalid parameters: {e!s}").to_dict(), | ||
| "error": JsonRpcInvalidParamsError().to_dict(), | ||
| "id": request_id, | ||
| } | ||
|
|
||
| @@ -525,7 +523,7 @@ | ||
| logger.error(f"Internal error in method {method}: {e}", exc_info=True) | ||
| return { | ||
| "jsonrpc": "2.0", | ||
| "error": JsonRpcInternalError(f"Internal error: {e!s}").to_dict(), | ||
| "error": JsonRpcInternalError().to_dict(), | ||
| "id": request_id, | ||
| } | ||
|
|
Copilot is powered by AI and may make mistakes. Always verify output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.