Refactor test infrastructure to use centralized container management #245
Conversation
|
🤖 Claude Code Review Status: Complete Current Review: History:
Summary: |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| containerManager, err = containers.NewContainerManager(containers.UTXOStoreType(opts.UTXOStoreType)) | ||
| require.NoError(t, err, "Failed to create container manager") | ||
|
|
||
| utxoStoreURL, err := containerManager.Initialize(ctx) |
There was a problem hiding this comment.
Resource leak: If daemon initialization fails after this point, the container won't be cleaned up because td.Stop() is never called. Register cleanup with t.Cleanup() immediately after container initialization to prevent leaks.
There was a problem hiding this comment.
✅ Fixed: Cleanup is now registered with t.Cleanup() immediately after container initialization (line 332-336).
|
|
||
| cm.postgresContainer = postgresC | ||
|
|
||
| connStr, err := postgresC.ConnectionString(ctx) |
There was a problem hiding this comment.
Potential resource leak: If ConnectionString() (line 157) or url.Parse() (line 185) fails after the container is successfully created, the PostgreSQL container will not be terminated. Consider assigning cm.cleanupFunc immediately after line 155 (before operations that might fail) to ensure the container is cleaned up on all error paths.
1 participant
No description provided.