Feature/complete with wallet #330
Draft
+901
−294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonesnotes
approved these changes
Jul 26, 2025
Collaborator
tonesnotes
left a comment
tonesnotes
left a comment
There was a problem hiding this comment.
Would it make sense to have done this as a CreateActionArgs constructor? Allowing both the createAction and signAction flows to be supported?
|
tonesnotes
reviewed
Dec 1, 2025
Collaborator
tonesnotes
left a comment
tonesnotes
left a comment
There was a problem hiding this comment.
There should be a optional create action options argument to allow this path to make use of all the modes of transaction creation...
tonesnotes
requested changes
Dec 1, 2025
Collaborator
tonesnotes
left a comment
tonesnotes
left a comment
There was a problem hiding this comment.
Add optional options argument to allow create action options to be supplied, enabling all the modes of transaction creation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Transaction.completeWithWalletmethod. This will make it easy to use a BRC-100 wallet to handle signing and transaction finalization.Issues
Closes #315
Testing Procedure
Describe the tests you've added or any testing steps you've taken.
Checklist
CHANGELOG.mdwith my changesnpm run docandnpm run lintone final time before requesting a reviewts-standardnpm version patchso that my changes will trigger a new version to be released when they are merged