Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Abondoned) Add lnbits #873

Open
wants to merge 61 commits into
base: 2.0
Choose a base branch
from
Open

(Abondoned) Add lnbits #873

wants to merge 61 commits into from

Conversation

petzsch
Copy link
Contributor

@petzsch petzsch commented Jan 11, 2024

THIS PR is ABONDONED and will be closed in 1 month!
More details see the last post on the PR.

⚠️This pull request is a work in progress.
⚠️Warning: There are still many moving parts in this PR, test at your own risk and please don't use for production setups!
⚠️Warning: Switching to this branch, will update your setup to BTCPay Server 2.0

If you want to support the testing of this PR, you can check it out following:

  1. cd /root/BTCPayServer/btcpayserver-docker/ (or where you orginallly checked out the btcpayserver-docker repo)
  2. git remote set-url origin https://github.com/petzsch/btcpayserver-docker.git
  3. git pull
  4. git checkout add-lnbits
  5. follow the docs: here.

TODOs:

@petzsch petzsch marked this pull request as draft January 11, 2024 09:21
@petzsch petzsch marked this pull request as ready for review January 18, 2024 13:56
Copy link

@PatMulligan PatMulligan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add after line 171?
* [opt-add-lnbits](docker-compose-generator/docker-fragments/opt-add-lnbits.yml), for a self-hosted lnbits backed by BTCPay Server.

@petzsch
Copy link
Contributor Author

petzsch commented Jan 31, 2024

add after line 171? * [opt-add-lnbits](docker-compose-generator/docker-fragments/opt-add-lnbits.yml), for a self-hosted lnbits backed by BTCPay Server.

Thanks for pointing this out. I've added your suggestion.

@petzsch petzsch marked this pull request as draft February 9, 2024 09:16
@petzsch petzsch marked this pull request as ready for review February 14, 2024 17:19
@Meisterzunge
Copy link

When does this feature will be approved? Cant wait for it 🙃

@Meisterzunge
Copy link

The custom fragment works well!

Hint:
If you set the LNBITS_ALLOWED_USERS variable to your admin user ID, other users won't be able to login to your lnbits instance. You should remove this line from the sample fragment wich will be part of the documentation. Or add a proper comment to it.

@petzsch
Copy link
Contributor Author

petzsch commented Oct 30, 2024

Please note: I've merged the 2.0 branch into this PR's branch. This means when you run an btcpay-update.sh you will get the new 2.0 Release.

Please read this for understanding breaking changes: https://blog.btcpayserver.org/btcpay-server-2-0/

@petzsch petzsch changed the base branch from master to 2.0 November 2, 2024 10:23
@petzsch
Copy link
Contributor Author

petzsch commented Dec 2, 2024

This fragment is abandoned!

Here the instructions to remove it from your BTCPay Setup. Remember to also remove it from your Store settings, if you used the lndhub interface.

  1. export LNBITS_HOST="(empty)"
  2. check your current fragment list with: printenv | grep -i additional_fragments

the output could look something like this:

BTCPAYGEN_ADDITIONAL_FRAGMENTS=opt-save-storage-s;opt-add-lnbits;opt-add-lnbits-admin.custom

remove the lnbits related fragments from the list and re-export the variable:

export BTCPAYGEN_ADDITIONAL_FRAGMENTS="opt-save-storage-s"

  1. cd /root/BTCPayServer/btcpayserver-docker
  2. git remote set-url origin https://github.com/btcpayserver/btcpayserver-docker.git
  3. git pull
  4. git checkout 2.0
  5. . btcpay-setup.sh -i
  6. btcpay-update.sh

There will be no future updates from my end. This PR will be closed 2nd Jan 2025.

Alternatives

For Boltcard functionality checkout @NicolasDorier 's plugin.

For hosting Lnbits you can checkout their SaaS service.

@petzsch petzsch changed the title Add lnbits (Abondoned) Add lnbits Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants