Updates and fixes #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
very useful test from travis
Newer releases of Module::Install don't like extra stanzas that were in the Makefile.PL, so remove them. Additionally, rework test to not rely on external web resources by mocking the setup with a HTTP::Server::Simple derived webserver Signed-off-by: Gary Greene <greeneg@tolharadys.net>
Signed-off-by: Gary Greene <greeneg@tolharadys.net>
Signed-off-by: Gary Greene <greeneg@tolharadys.net>
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Aug 21, 2020
- EAPI7 - Convert 'sed' hack to a patch - Strip bundled deps in inc/ which got used in testing and reported bogus warnings that will probably become fatal in future, in favour ot using system dependencies. - Inhale a modified version of a set of patches submitted upstream that makes the http tests not require a live internet connection to be tested, at the cost of *many* dependencies. But manual steps are no longer required to properly test this \o/ Bug: btrott/Feed-Find#2 Package-Manager: Portage-2.3.103, Repoman-2.3.22 Signed-off-by: Kent Fredric <kentnl@gentoo.org>
|
@btrott any chance this could be merged and a new release pushed? There are now lots of failing builds for apps that depend on this dependency, due to the failing tests. |
|
I would also love it if @btrott would accept this PR and create a new release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR incorporates the changes from @mishin and updates the Makefile.PL to work correctly with recent releases of Module::Install, plus makes changes to the
./t/01-find.ttest.The changes to the
t/01-find.tallow the test to run locally without dependency on external web resources by using Test::HTTP::Server::Simple and CGI::Application::Server to mock a site hosting the anchors-only.html file.