Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance by grouping and limiting via DB queries #65

Merged
merged 5 commits into from
Jan 23, 2025

Conversation

btschwertfeger
Copy link
Owner

@btschwertfeger btschwertfeger commented Jan 22, 2025

Summary

  • Adding and improving comments
  • Making use of limiting and ordering orders from the orderbook

@btschwertfeger btschwertfeger added enhancement New feature or request technical dept Things that could be improved labels Jan 22, 2025
@btschwertfeger btschwertfeger added this to the v1.0.0 milestone Jan 22, 2025
@btschwertfeger btschwertfeger self-assigned this Jan 22, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.35%. Comparing base (a293bdc) to head (6c2f4d3).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #65      +/-   ##
==========================================
+ Coverage   85.10%   85.35%   +0.24%     
==========================================
  Files           6        6              
  Lines         920      922       +2     
==========================================
+ Hits          783      787       +4     
+ Misses        137      135       -2     
Flag Coverage Δ
unittests 85.35% <100.00%> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/kraken_infinity_grid/database.py 84.65% <100.00%> (+0.67%) ⬆️
src/kraken_infinity_grid/gridbot.py 70.99% <100.00%> (ø)
src/kraken_infinity_grid/order_management.py 92.00% <100.00%> (+0.59%) ⬆️
src/kraken_infinity_grid/setup.py 98.92% <ø> (ø)

@btschwertfeger btschwertfeger changed the title Misc improvements Improve performance by grouping and limiting via DB queries Jan 22, 2025
@btschwertfeger btschwertfeger marked this pull request as ready for review January 23, 2025 06:16
@btschwertfeger btschwertfeger merged commit 58b9f45 into master Jan 23, 2025
29 checks passed
@btschwertfeger btschwertfeger deleted the cleanup branch January 23, 2025 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request technical dept Things that could be improved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants