Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve "Replace the deprecated calls to async_close and stop to terminate sessions" #88

Conversation

btschwertfeger
Copy link
Owner

Summary

The async_close and stop functions that either close the websocket or iohttp sessions were replaced by the close function that the SDK will provide in version v3.1.6.

Closes #87

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.99%. Comparing base (3c6fd81) to head (7062e2b).

Files with missing lines Patch % Lines
src/kraken_infinity_grid/gridbot.py 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #88      +/-   ##
==========================================
+ Coverage   85.80%   85.99%   +0.18%     
==========================================
  Files           6        6              
  Lines         916      914       -2     
==========================================
  Hits          786      786              
+ Misses        130      128       -2     
Flag Coverage Δ
unittests 85.99% <0.00%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/kraken_infinity_grid/gridbot.py 72.05% <0.00%> (+0.62%) ⬆️

@btschwertfeger btschwertfeger marked this pull request as ready for review February 16, 2025 08:05
@btschwertfeger btschwertfeger merged commit f945185 into master Feb 16, 2025
29 checks passed
@btschwertfeger btschwertfeger deleted the 87-replace-the-deprecated-calls-to-async_close-and-stop-to-terminate-sessions branch February 16, 2025 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical dept Things that could be improved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace the deprecated calls to async_close and stop to terminate sessions
2 participants