test: strengthen scope dependency notifications #810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add tests for previously untested animation components: - SpringCurve: physics-based curve behavior and constructors - Keyframe/KeyframeTrack: construction, equality, sequence generation - KeyframeAnimationResult: get<T>() with error handling - NoAnimationDriver: instant spec changes without interpolation - CurveAnimationConfig: delay, totalDuration, copyWith, spring factories - AnimationConfigUtility: implicit() and call() methods These tests increase coverage of the animation infrastructure from ~58 tests to ~150+ meaningful behavior tests.
- SpringCurve stiffness test: verify different curves instead of ordering - NoAnimationDriver: check AnimationStatus.forward (AlwaysStoppedAnimation behavior) - Remove unnecessary import in animation_util_test
Animation tests: - PhaseAnimationConfig: unit tests for params, onEnd, equality (previously untested) - StyleAnimationBuilder: driver switching tests (curve→spring, animation→none) Provider tests: - TextScope: default value verification (softWrap, overflow, textWidthBasis, style) - TextScope/IconScope: nested scope override behavior - TextScope/IconScope: deep nesting access tests These tests catch real composition and configuration change bugs.
|
To view this pull requests documentation preview, visit the following URL: Documentation is deployed and generated using docs.page. |
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary\n- make IconScope/TextScope tests assert dependency notifications via didChangeDependencies\n- make StyleAnimationDriver reset test meaningful and dispose local ValueNotifiers\n\n## Testing\n- not run (not requested)