Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mask): add support for -webkit-mask and -webkit-mask-image #382

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

amiratak88
Copy link
Contributor

Description

Add support for mask and mask-image properties for browsers that support them via webkit.

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Enhancement (changes that improvement of current feature or performance)
  • Refactoring (changes that neither fixes a bug nor adds a feature)
  • Test Case (changes that add missing tests or correct existing tests)
  • Code style optimization (changes that do not affect the meaning of the code)
  • Docs (changes that only update documentation)
  • Chore (changes that don't modify src or test files)

Self Check before Merge

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Add support for `mask` and `mask-image` properties for browsers that support them via webkit.

# 334
@biiibooo
Copy link
Contributor

biiibooo bot commented Mar 9, 2023

👋 @amiratak88

💖 Thanks for opening this pull request! 💖

Please follow the contributing guidelines. And we use semantic commit messages to streamline the release process.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add graph.scale() method
  • docs: graph.getShortestPath is now available

Things that will help get your PR across the finish line:

  • Follow the TypeScript coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 62.93%. Comparing base (b751cbf) to head (569a944).
Report is 51 commits behind head on master.

Files with missing lines Patch % Lines
src/embed-images.ts 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #382   +/-   ##
=======================================
  Coverage   62.93%   62.93%           
=======================================
  Files          10       10           
  Lines         580      580           
  Branches      143      143           
=======================================
  Hits          365      365           
  Misses        151      151           
  Partials       64       64           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lorenzhh
Copy link

lorenzhh commented Jul 8, 2023

What is the status of this PR?

@gilkeyio
Copy link

gilkeyio commented May 9, 2024

Would love to see this get merged! I've run a local fork with these changes, and they work great for me.

@matthew-h-wang
Copy link

Please merge this soon!

@bubkoo bubkoo merged commit 5bdfda7 into bubkoo:master Feb 13, 2025
@biiibooo
Copy link
Contributor

biiibooo bot commented Feb 13, 2025

👋 @amiratak88 Congrats on merging your first pull request! 🎉🎉🎉

biiibooo bot added a commit that referenced this pull request Feb 14, 2025
## [1.11.13](v1.11.12...v1.11.13) (2025-02-14)

### Bug Fixes

* **mask:** add support for -webkit-mask and -webkit-mask-image ([#382](#382)) ([5bdfda7](5bdfda7))
@biiibooo
Copy link
Contributor

biiibooo bot commented Feb 14, 2025

🎉 This PR is included in version 1.11.13 🎉

The release is available on:

Your semantic-release bot 📦🚀

@biiibooo biiibooo bot added the released label Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants