-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: svg cloning optimized using deep clone #462
Conversation
💖 Thanks for opening this pull request! 💖 Please follow the contributing guidelines. And we use semantic commit messages to streamline the release process. Examples of commit messages with semantic prefixes:
Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
Sorry, not sure what is wrong with Label step, but fix worth to review. It's significantly improve the speed in case when HTML contain SVG images. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #462 +/- ##
==========================================
+ Coverage 62.93% 63.10% +0.17%
==========================================
Files 10 10
Lines 580 580
Branches 143 143
==========================================
+ Hits 365 366 +1
Misses 151 151
+ Partials 64 63 -1 ☔ View full report in Codecov by Sentry. |
👋 @jagermesh Congrats on merging your first pull request! 🎉🎉🎉 |
## [1.11.12](v1.11.11...v1.11.12) (2025-02-12) ### Bug Fixes * add possibility to use own handling of onerror which will not en… ([#453](#453)) ([04160c3](04160c3)) * ensure images are totally prcoessed before using them (ios) ([#478](#478)) ([51fb98f](51fb98f)) * Fix `fontEmbedCSS ` incorrect sizing ([#422](#422)) ([7020162](7020162)) ### Performance Improvements * embed only used fonts ([#476](#476)) ([09bee44](09bee44)) * svg cloning optimized using deep clone ([#462](#462)) ([9aac2fd](9aac2fd))
🎉 This PR is included in version 1.11.12 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Optimize cloning of SVG elements
Description
Instead of cloning each child SVG element (which in my case is around 200) we can use cloneNode(true) to use deep clone mode
Motivation and Context
Converting DIV with SVG inside taking around 20 second in Safari and around 15 in Chrome
Types of changes
Self Check before Merge