Skip to content

Commit

Permalink
Do not use TMPDIR if we are providing a path via DBDPG_TEMDIR environ…
Browse files Browse the repository at this point in the history
…ment varaible.

Per suggestion on RT #157598
  • Loading branch information
turnstep committed Dec 20, 2024
1 parent 7c6c1e0 commit b7ccf3c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion t/dbdpg_test_setup.pl
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,7 @@ sub connect_database {
$su = $testuser = '';

$testdir = exists $ENV{DBDPG_TEMPDIR} ?
File::Temp::tempdir("$ENV{DBDPG_TEMPDIR}/dbdpg_testdatabase_XXXXXX", TMPDIR => 1, CLEANUP => 0) :
File::Temp::tempdir("$ENV{DBDPG_TEMPDIR}/dbdpg_testdatabase_XXXXXX", CLEANUP => 0) :

This comment has been minimized.

Copy link
@haarg

haarg Dec 21, 2024

This change makes sense, but this file includes another code path with the same problem at https://github.com/bucardo/dbdpg/blob/master/t/dbdpg_test_setup.pl#L828-L829

This comment has been minimized.

Copy link
@esabol

esabol Dec 21, 2024

Contributor

@turnstep: Yes, I agree with @haarg.

File::Temp::tempdir('dbdpg_testdatabase_XXXXXX', TMPDIR => 1, CLEANUP => 0);

my $readme = "$testdir/README";
Expand Down

0 comments on commit b7ccf3c

Please sign in to comment.