Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PROD-7937] In Plugin Notification system #4518

Open
wants to merge 21 commits into
base: release
Choose a base branch
from
Open

[PROD-7937] In Plugin Notification system #4518

wants to merge 21 commits into from

Conversation

annrra
Copy link
Contributor

@annrra annrra commented Sep 25, 2024

Jira Issue:

https://buddyboss.atlassian.net/browse/PROD-7937

General Note

Keep all conversations related to this PR in the associated Jira issue(s). Do NOT add comment on this PR or edit this PR’s description.

Notes to Developer

  • Ensure the IDs (i.e. PROD-1) of all associated Jira issues are reference in this PR’s title
  • Ensure that you have achieved the Definition of Done before submitting for review
  • When this PR is ready for review, move the associate Jira issue(s) to “Needs Review” (or “Code Review” for Dev Tasks)

Notes to Reviewer

  • Ensure that the Definition of Done have been achieved before approving a PR
  • When this PR is approved, move the associated Jira issue(s) to “Needs QA” (or “Approved” for Dev Tasks)

@annrra annrra self-assigned this Sep 25, 2024
annrra and others added 20 commits September 25, 2024 22:47
…ogic to switch between tabs and dismiss notices
- Add class for in plugin notification, Also load that class as autoload
- Called css and js from class
- Removed required_once, instead of that use `add_action( 'in_admin_header', array( $this, 'bb_admin_notification_header' ), 0 );` to call html in admin header
- Remove unwanted changes
- uncommented code to direct access class file
- Update doc block comment
* release: (58 commits)
Update: Grunt
Update: Grunt string-replace
Update: Version name update
Added change log
grunt
grunt fix
PROD-7989 - pulled api changes from repo
PROD-8055 - updated suffix to be more precise
PROD-8055 - Added “rapydapps.cloud” suffix to URLs considered as staging sites for Rapyd Customer
PROD-8044 - Fix - Release notes not display correctly if downgrade version
PROD-7681: Fixed profile type visibility on activity reaction reacted user list
PROD-7938 - Optimise memory
PROD-7938 - phpcbf
PROD-7938 - html formatting
PROD-7938 - Update doc block comment
PROD-7938 - Display notice again once user logout. So need to delete transient when admin logged out
PROD-7938 - Move ajax action into bp-core-admin-actions.php file. - Code refator
PROD-7938 - Update transient for 24h
PROD-7938 - Update icon
PROD-7998 - Refactor: Modify the variables and add comments.
...

# Conflicts:
#	src/bp-core/admin/bp-core-admin-actions.php
- Display notification based on fetched notification from servers
- Update action name - admin_init to bp_admin_init
- Display notification dynamically
- Also update code to dismiss notice
…uld not display

- Code refactor
- Update message if not any notifications
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants