Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove excess intent fetching on /training/intents page #731

Merged
merged 26 commits into from
Dec 11, 2024
Merged

Remove excess intent fetching on /training/intents page #731

merged 26 commits into from
Dec 11, 2024

Conversation

IgorKrupenja
Copy link
Collaborator

@IgorKrupenja IgorKrupenja commented Dec 3, 2024 •
edited
Loading

Related task:

This PR:

  • Resolves most issues with excessive data fetching on intents page. Previously all intent data for all intents was fetched every time. This was very slow and not scalable. Now, I split off a separate IntentDetails component where detailed data is fetched only for the selected intent. The Intents/index.tsx itself now only fetches minimum data required to render the list.
  • Response and rule fetching is not fixed in this PR, these still fetch data for all requests. This will be implemented in later PRs.
  • This IntentDetails component is also going to be used with common intents page to remove the significant code duplication. I will implement this in a later PR.
  • Fixes a couple minor issues, mostly related to types. It was very difficult to work otherwise.

@IgorKrupenja IgorKrupenja mentioned this pull request Dec 4, 2024
Closed
@IgorKrupenja IgorKrupenja changed the title Fix excessive fetching part 1 WIP Fix excessive fetching of intent data Dec 4, 2024
@IgorKrupenja IgorKrupenja marked this pull request as ready for review December 4, 2024 11:21
@IgorKrupenja IgorKrupenja mentioned this pull request Dec 4, 2024
Open
13 tasks
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 4, 2024

Quality Gate Passed Quality Gate passed

Issues
10 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
2.5% Duplication on New Code

See analysis details on SonarQube Cloud

@turnerrainer turnerrainer linked an issue Dec 5, 2024 that may be closed by this pull request
Remove excess data fetching in Training Module #700
Open
13 tasks
This was referenced Dec 5, 2024
Merged
Open
Merged
Open
@turnerrainer turnerrainer linked an issue Dec 9, 2024 that may be closed by this pull request
Remove excess intent fetching on /training/intents page #742
Open
2 tasks
This was referenced Dec 10, 2024
Open
Merged
@IgorKrupenja IgorKrupenja changed the title Fix excessive fetching of intent data Remove excess intent fetching on /training/intents page Dec 10, 2024
1AhmedYasser
1AhmedYasser approved these changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@1AhmedYasser 1AhmedYasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IgorKrupenja
Copy link
Collaborator Author

IgorKrupenja commented Dec 11, 2024 •
edited
Loading

2.5% code duplication reported by Sonar is expected due to Intents and Common Intents pages having duplicate code before, introduced way back. We will get rid of this in the next task: #743

@turnerrainer turnerrainer merged commit 746a322 into buerokratt:v2.0.2 Dec 11, 2024
4 checks passed
@IgorKrupenja IgorKrupenja mentioned this pull request Dec 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1AhmedYasser 1AhmedYasser 1AhmedYasser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove excess intent fetching on /training/intents page Remove excess data fetching in Training Module
3 participants
@IgorKrupenja @1AhmedYasser @turnerrainer