Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove excess data fetching on /training/common-intents page #755

Merged
merged 54 commits into from
Dec 13, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
54 commits
Select commit Hold shift + click to select a range
6316b3b
Merge relevant from old branch
IgorKrupenja Dec 3, 2024
47d942c
Fix guard
IgorKrupenja Dec 3, 2024
b10dc8d
Fix response logic
IgorKrupenja Dec 3, 2024
37dfc75
Fix deps
IgorKrupenja Dec 3, 2024
06ecd85
Remove deupe code
IgorKrupenja Dec 3, 2024
5f6230e
TODOs
IgorKrupenja Dec 3, 2024
2340c4c
Revert unrelated changes
IgorKrupenja Dec 3, 2024
26f57fc
Clean up
IgorKrupenja Dec 3, 2024
c9750b9
Clean up
IgorKrupenja Dec 3, 2024
9f73066
Clean up
IgorKrupenja Dec 3, 2024
e916819
Fix deletion
IgorKrupenja Dec 3, 2024
b73c29f
Clean up
IgorKrupenja Dec 3, 2024
6e6b23e
Move entities
IgorKrupenja Dec 3, 2024
4faea19
Clean up
IgorKrupenja Dec 3, 2024
3ebaaf8
Clean up
IgorKrupenja Dec 3, 2024
f1fefc2
Fix adding example
IgorKrupenja Dec 3, 2024
df075da
Fix examples
IgorKrupenja Dec 3, 2024
ec52131
Clean up
IgorKrupenja Dec 3, 2024
048941e
Clean up
IgorKrupenja Dec 3, 2024
4596ee3
Clean up
IgorKrupenja Dec 3, 2024
802eed2
Fix rule
IgorKrupenja Dec 4, 2024
efad763
Fix editing example
IgorKrupenja Dec 4, 2024
4b4bd07
gsa
IgorKrupenja Dec 4, 2024
8786af7
Clean up
IgorKrupenja Dec 4, 2024
f785f2f
Clean up
IgorKrupenja Dec 4, 2024
5a11419
Clean up
IgorKrupenja Dec 4, 2024
871fc7d
Fix the issue
IgorKrupenja Dec 5, 2024
ef68b39
PoC without data mapping
IgorKrupenja Dec 6, 2024
705cb8f
PoC with poor format
IgorKrupenja Dec 6, 2024
9fa9066
PoC with better format
IgorKrupenja Dec 6, 2024
8e97646
Clean up
IgorKrupenja Dec 6, 2024
96153ef
Cle
IgorKrupenja Dec 6, 2024
c41897e
PoC component
IgorKrupenja Dec 6, 2024
3d770c8
Clean up
IgorKrupenja Dec 6, 2024
fe8ce3f
Fix name
IgorKrupenja Dec 6, 2024
3c154c6
Fix query
IgorKrupenja Dec 6, 2024
265107c
Fix fetch
IgorKrupenja Dec 6, 2024
5def279
Revert unrelated changes
IgorKrupenja Dec 6, 2024
6921388
Clean up
IgorKrupenja Dec 6, 2024
4e33c26
Clean up
IgorKrupenja Dec 6, 2024
52534ec
Clean up
IgorKrupenja Dec 9, 2024
746588b
Clean up
IgorKrupenja Dec 10, 2024
b8b60ec
PoC request
IgorKrupenja Dec 10, 2024
c44fcd0
Finish
IgorKrupenja Dec 10, 2024
49671fe
PoC common component
IgorKrupenja Dec 11, 2024
be3a076
Working PoC
IgorKrupenja Dec 11, 2024
188b8c7
Extract hook
IgorKrupenja Dec 11, 2024
c2d5ddb
Use hok in common
IgorKrupenja Dec 11, 2024
80c1c1d
Clean up
IgorKrupenja Dec 11, 2024
b9d5df4
Clean up
IgorKrupenja Dec 11, 2024
a343147
Clean up
IgorKrupenja Dec 11, 2024
e8fd874
Remove dupe list code
IgorKrupenja Dec 11, 2024
422b802
Remove unused files
IgorKrupenja Dec 11, 2024
ffde112
Merge base
IgorKrupenja Dec 13, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 0 additions & 20 deletions DSL/DMapper/hbs/get_intents_full.handlebars

This file was deleted.

15 changes: 0 additions & 15 deletions DSL/DMapper/hbs/get_intents_with_examples.handlebars

This file was deleted.

2 changes: 1 addition & 1 deletion DSL/DMapper/hbs/get_intents_with_examples_count.handlebars
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
{{#each buckets}}
{
"id": "{{key}}",
"examples_count": {{examples_counts.value}},
"examplesCount": {{examples_counts.value}},
"inModel": {{isInModel key ../intents}},
"modifiedAt": "{{findModifiedAt key ../intents/intentsModifiedAt}}"
}{{#unless @last}},{{/unless}}
Expand Down
18 changes: 9 additions & 9 deletions DSL/OpenSearch/templates/intents-with-examples-count.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,18 +19,18 @@
}
},
"query": {
{{#intent}}
"wildcard": {
"intent": "*{{intent}}*"
"prefix": {
"intent": {
"value": "{{prefix}}"
}
}
{{/intent}}
{{^intent}}
"match_all": {}
{{/intent}}
}
},
"params": {
"intent": ""
"prefix": {
"type": "string",
"description": "Optional prefix to filter intents"
}
}
}
}
}
88 changes: 0 additions & 88 deletions DSL/Ruuter.private/GET/rasa/intents/common.yml

This file was deleted.

96 changes: 0 additions & 96 deletions DSL/Ruuter.private/GET/rasa/intents/full.yml

This file was deleted.

10 changes: 10 additions & 0 deletions DSL/Ruuter.private/GET/rasa/intents/with-examples-count.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,23 @@ declaration:
- field: cookie
type: string
description: "Cookie field"
params:
- field: prefix
type: string
description: "Prefix to filter intents"

assignValues:
assign:
prefix: ${incoming.params.prefix}

getIntentsExampleCount:
call: http.post
args:
url: "[#TRAINING_OPENSEARCH]/intents/_search/template"
body:
id: "intents-with-examples-count"
params:
prefix: ${prefix || ''}
result: getIntentsResult

getDomainFile:
Expand Down
Loading