Skip to content

Commit

Permalink
Drop extension TODO
Browse files Browse the repository at this point in the history
  • Loading branch information
emcfarlane committed Mar 4, 2025
1 parent cffd97c commit b460387
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions private/bufpkg/bufimage/bufimageutil/image_filter.go
Original file line number Diff line number Diff line change
Expand Up @@ -201,8 +201,6 @@ func (b *sourcePathsBuilder) remapFileDescriptor(
return nil, err
}
isDirty = isDirty || changed
// TODO: extension docs
//newExtensions, changed, err := remapSlice(sourcePathsRemap, append(sourcePath, fileExtensionsTag), fileDescriptor.Extension, b.remapField)
newExtensions, changed, err := remapSlice(sourcePathsRemap, append(sourcePath, fileExtensionsTag), fileDescriptor.Extension, b.remapField, b.options)
if err != nil {
return nil, err
Expand Down Expand Up @@ -257,7 +255,6 @@ func (b *sourcePathsBuilder) remapFileDescriptor(
publicDependencyPath := append(sourcePath, filePublicDependencyTag)
sourcePathsRemap.markDeleted(publicDependencyPath)

// TODO: validate
newFileDescriptor.WeakDependency = nil
if len(fileDescriptor.WeakDependency) > 0 {
weakDependencyPath := append(sourcePath, fileWeakDependencyTag)
Expand Down Expand Up @@ -325,8 +322,6 @@ func (b *sourcePathsBuilder) remapDescriptor(
newDescriptor.ExtensionRange = newExtensionRange
}
}
// TODO: sourcePath might not be correct here.
// TODO: extension docs.
newExtensions, changed, err := remapSlice(sourcePathsRemap, append(sourcePath, messageExtensionsTag), descriptor.GetExtension(), b.remapField, b.options)
if err != nil {
return nil, false, err
Expand Down

0 comments on commit b460387

Please sign in to comment.