Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Protobuf plugin by kanro #166

Merged
merged 11 commits into from
Jan 23, 2024
Merged

Support Protobuf plugin by kanro #166

merged 11 commits into from
Jan 23, 2024

Conversation

devkanro
Copy link
Contributor

@devkanro devkanro commented Dec 20, 2023

This PR make buf plugin support the IntelliJ Protobuf Plugin by @devkanro, hereafter referred to as the Protobuf plugin.

The buf plugin previously only supported the Protobuf plugin provided by JetBrains, hereafter referred to as the official plugin.

This Protobuf plugin is more feature rich than the official plugin, please see the GitHub home page for details..

I make both the deps of official plugin and protobuf plugin be optional, the buf plugin will work fine with anyone for them.

Resolve

@CLAassistant
Copy link

CLAassistant commented Dec 20, 2023

CLA assistant check
All committers have signed the CLA.

@nicksnyder
Copy link
Member

Thanks for the contribution! Relevant reviewers are on vacation so we can take a look after they are back. In the meantime, it looks like CI doesn't pass with this change.

@devkanro
Copy link
Contributor Author

Currently, the IDEA test framework does not support configuring the missing optional plugin, so I did not update some tests in the protobuf plugin, and the current test plan remains unchanged (only testing when the official plugin is enabled).

devkanro referenced this pull request in devkanro/intellij-protobuf-plugin Dec 26, 2023
@devkanro
Copy link
Contributor Author

@nicksnyder Could you approval the workflows to run the tests.

Copy link
Member

@nicksnyder nicksnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some check warnings on this diff. You can see them inline when you view the PR diff or you can see the check output here: https://github.com/bufbuild/intellij-buf/actions/runs/7338528883

@devkanro
Copy link
Contributor Author

devkanro commented Jan 3, 2024

@nicksnyder Could you approval the workflows to run the tests again.

@nicksnyder nicksnyder requested a review from pkwarren January 3, 2024 12:35
build.gradle.kts Outdated Show resolved Hide resolved
gradle.properties Outdated Show resolved Hide resolved
gradle.properties Outdated Show resolved Hide resolved
Co-authored-by: Philip K. Warren <pkwarren@users.noreply.github.com>
@devkanro
Copy link
Contributor Author

devkanro commented Jan 9, 2024

@pkwarren Plz approval the workflows to run the tests again.

Copy link
Member

@pkwarren pkwarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good. We're discussing this PR more internally as there are some ongoing changes in this area we're working on.

@Alfus
Copy link

Alfus commented Jan 22, 2024

FYI, we filed devkanro/intellij-protobuf-plugin#229 as a potental avenue for deeper integration.

Copy link
Member

@nicksnyder nicksnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing this!

@nicksnyder nicksnyder merged commit 6fbe91e into bufbuild:main Jan 23, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants