-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Protobuf plugin by kanro #166
Conversation
Thanks for the contribution! Relevant reviewers are on vacation so we can take a look after they are back. In the meantime, it looks like CI doesn't pass with this change. |
Currently, the IDEA test framework does not support configuring the missing optional plugin, so I did not update some tests in the protobuf plugin, and the current test plan remains unchanged (only testing when the official plugin is enabled). |
@nicksnyder Could you approval the workflows to run the tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some check warnings on this diff. You can see them inline when you view the PR diff or you can see the check output here: https://github.com/bufbuild/intellij-buf/actions/runs/7338528883
src/main/kotlin/build/buf/intellij/annotator/BufAnalyzeModificationTracker.kt
Outdated
Show resolved
Hide resolved
@nicksnyder Could you approval the workflows to run the tests again. |
Co-authored-by: Philip K. Warren <pkwarren@users.noreply.github.com>
@pkwarren Plz approval the workflows to run the tests again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look good. We're discussing this PR more internally as there are some ongoing changes in this area we're working on.
FYI, we filed devkanro/intellij-protobuf-plugin#229 as a potental avenue for deeper integration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for contributing this!
This PR make buf plugin support the IntelliJ Protobuf Plugin by @devkanro, hereafter referred to as the Protobuf plugin.
The buf plugin previously only supported the Protobuf plugin provided by JetBrains, hereafter referred to as the official plugin.
This Protobuf plugin is more feature rich than the official plugin, please see the GitHub home page for details..
I make both the deps of official plugin and protobuf plugin be optional, the buf plugin will work fine with anyone for them.
Resolve