Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert comment methods on descriptor types to helper functions #748

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

srikrsna-buf
Copy link
Member

Convert comment methods on descriptor types to helper functions. These have little to no use at application runtime but are most useful for plugin authors, the new functions are part of @bufbuild/protoplugin. This also helps reduce the bundle size of @bufbuild/protobuf.

@srikrsna-buf srikrsna-buf requested a review from timostamm March 14, 2024 12:37
@srikrsna-buf srikrsna-buf requested a review from timostamm March 14, 2024 15:54
@srikrsna-buf srikrsna-buf merged commit 5f85bd5 into v2 Mar 14, 2024
5 checks passed
@srikrsna-buf srikrsna-buf deleted the sk/comment branch March 14, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants