Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add toBinary and fromBinary functions #751

Merged
merged 5 commits into from
Mar 18, 2024
Merged

Add toBinary and fromBinary functions #751

merged 5 commits into from
Mar 18, 2024

Conversation

srikrsna-buf
Copy link
Member

@srikrsna-buf srikrsna-buf commented Mar 18, 2024 •
edited
Loading

Add toBinary and fromBinary functions to serialize to and from protobuf encoded bytes. Added compatibility tests with v1 for now.

@srikrsna-buf srikrsna-buf requested a review from timostamm March 18, 2024 09:21
timostamm
timostamm reviewed Mar 18, 2024
View reviewed changes
packages/protobuf/src/next/from-binary.ts Outdated Show resolved Hide resolved
packages/protobuf/src/next/from-binary.ts Show resolved Hide resolved
packages/protobuf/src/next/to-binary.ts Outdated Show resolved Hide resolved
packages/protobuf/src/next/to-binary.ts Outdated Show resolved Hide resolved
@srikrsna-buf srikrsna-buf requested a review from timostamm March 18, 2024 12:10
@srikrsna-buf srikrsna-buf merged commit 689daf3 into v2 Mar 18, 2024
5 checks passed
@srikrsna-buf srikrsna-buf deleted the sk/binary branch March 18, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timostamm timostamm timostamm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@srikrsna-buf @timostamm