Skip to content

Add support for parsing into an existing message #756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 20, 2024
Merged

Add support for parsing into an existing message #756

merged 4 commits into from
Mar 20, 2024

Conversation

srikrsna-buf
Copy link
Member

Add support parsing into an existing message. Behavior is the same as v1:

  • Repeated fields are appended.
  • Map entries are added, overwriting existing keys.
  • If a message field is already present, it will be merged with the new data.

@srikrsna-buf srikrsna-buf requested a review from timostamm March 20, 2024 02:34
@srikrsna-buf srikrsna-buf changed the title Add support parsing into an existing message. Add support for parsing into an existing message Mar 20, 2024
@srikrsna-buf srikrsna-buf requested a review from timostamm March 20, 2024 13:23
@srikrsna-buf srikrsna-buf merged commit 8a4f83c into v2 Mar 20, 2024
5 of 6 checks passed
@srikrsna-buf srikrsna-buf deleted the sk/merge branch March 20, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timostamm timostamm timostamm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@srikrsna-buf @timostamm