Merged
Conversation
timostamm
reviewed
Mar 21, 2024
Member
timostamm
left a comment
timostamm
left a comment
There was a problem hiding this comment.
LGTM
(Edited the PR description, adding more context)
timostamm
approved these changes
Mar 21, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support unknown fields in the method
Message.clone().Extensions are stored as unknown fields on a message, and cloning a message will currently discard any set extension. This behavior is unexpected, since it would be logical that a deep copy includes all properties that were explicitly set, whether it is a regular field, or an extension.
This PR fixes this flaw, and includes unknown fields when cloning a message.
This also documents equal's behavior of ignoring the unknown fields and extensions.