Add support for shared field constraints #60
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There doesn't seem to be any practical way to either globally register extensions or have CppProtobuf recursively handle option extensions through a chosen MessageFactory/DescriptorPool so we wind up needing to push the logic to reparse dynamic extensions all the way down to the bottom when the rules structure is evaluated. This adds a small addition to the API surface,
ValidatorFactory::SetMessageFactory
, so that the end users (and conformance runner) can set a descriptor pool to use for reparsing.TODO:
This will depend on bufbuild/protovalidate#246.