Skip to content

Commit

Permalink
Bump github.com/bufbuild/protocompile from 0.7.1 to 0.8.0 in /tools (#…
Browse files Browse the repository at this point in the history
…159)

Bumps
[github.com/bufbuild/protocompile](https://github.com/bufbuild/protocompile)
from 0.7.1 to 0.8.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/bufbuild/protocompile/releases">github.com/bufbuild/protocompile's
releases</a>.</em></p>
<blockquote>
<h2>v0.8.0</h2>
<p>This release primarily fixes bugs in the compiler that resulted in
differences between the source files that protocompile would accept vs.
the source files that the reference compiler, <code>protoc</code>, would
accept. But one of these changes resulted in an unused AST node type. So
this type has been removed from the exported API, which is why this
v0.8.0 instead of v0.7.2.</p>
<p>Fixes:</p>
<ol>
<li>A <code>protocompile.Compiler</code> would previously accept some
sources that would be rejected by <code>protoc</code>. In particular,
<code>protocompile</code> allowed for explicitly-signed positive numeric
literals -- with a leading plus (+) sign. But this is not allowed by the
reference compiler, <code>protoc</code>, nor by implementations of the
text format in myriad languages (which is also the format the compiler
uses to parse custom option values that are message literals).
<ul>
<li>This change is not backwards compatible. The AST node type
<code>ast.PositiveUintLiteralNode</code> has been removed. It was only
used to support this invalid construct in the language. Code that refers
to this node type (or its associated factory function and
<code>Visitor</code> method) must be removed.</li>
</ul>
</li>
<li>A <code>protocompile.Compiler</code> would previously reject some
sources that would <code>protoc</code> would accept. In particular,
<code>protocompile</code> did not allow <code>-nan</code> as a default
field value or custom option value and it also did not accept
<code>inf</code> and alternate case spellings (such as upper- or
mixed-case) of <code>infinity</code> and <code>nan</code> in message
literals, which are all allowed by <code>protoc</code>.</li>
</ol>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/bufbuild/protocompile/commit/99139774000d61ad36cb8b8f8f11f55df407ae27"><code>9913977</code></a>
More precise &quot;go generate&quot; directive (<a
href="https://redirect.github.com/bufbuild/protocompile/issues/226">#226</a>)</li>
<li><a
href="https://github.com/bufbuild/protocompile/commit/72d7e6858968565a7b1f654f02fb7da8ea9f6ea3"><code>72d7e68</code></a>
Fix recently discovered discrepancies with <code>protoc</code> (<a
href="https://redirect.github.com/bufbuild/protocompile/issues/229">#229</a>)</li>
<li><a
href="https://github.com/bufbuild/protocompile/commit/93a9ef1b5c16ec759aca3547482faac237ee1c94"><code>93a9ef1</code></a>
Tolerate trailing '.' in unambiguous type name cases (<a
href="https://redirect.github.com/bufbuild/protocompile/issues/224">#224</a>)</li>
<li><a
href="https://github.com/bufbuild/protocompile/commit/4c57c2616db034ea4e6fe123b913d62613c39a06"><code>4c57c26</code></a>
Tolerate trailing '.' in option names (<a
href="https://redirect.github.com/bufbuild/protocompile/issues/222">#222</a>)</li>
<li><a
href="https://github.com/bufbuild/protocompile/commit/508b83b576daac033f3ca8258f63ab8a6d66e0c7"><code>508b83b</code></a>
Tolerate trailing ',' in compact options (<a
href="https://redirect.github.com/bufbuild/protocompile/issues/221">#221</a>)</li>
<li><a
href="https://github.com/bufbuild/protocompile/commit/f2f125444e89142543cb1b3e3b4b9a2b3b75cea3"><code>f2f1254</code></a>
Consolidate conversion logic (<a
href="https://redirect.github.com/bufbuild/protocompile/issues/220">#220</a>)</li>
<li><a
href="https://github.com/bufbuild/protocompile/commit/fe27e56f6edbe6f340d96c32c80c204d20e5ce0e"><code>fe27e56</code></a>
Bump golang.org/x/tools from 0.15.0 to 0.16.0 in /internal/tools (<a
href="https://redirect.github.com/bufbuild/protocompile/issues/208">#208</a>)</li>
<li>See full diff in <a
href="https://github.com/bufbuild/protocompile/compare/v0.7.1...v0.8.0">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github.com/bufbuild/protocompile&package-manager=go_modules&previous-version=0.7.1&new-version=0.8.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
  • Loading branch information
dependabot[bot] authored Jan 29, 2024
1 parent 400b978 commit 4b59272
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion tools/go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ module github.com/bufbuild/protovalidate/tools
go 1.21

require (
github.com/bufbuild/protocompile v0.7.1
github.com/bufbuild/protocompile v0.8.0
github.com/spf13/pflag v1.0.5
github.com/stretchr/testify v1.8.4
golang.org/x/sync v0.6.0
Expand Down
4 changes: 2 additions & 2 deletions tools/go.sum
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
github.com/bufbuild/protocompile v0.7.1 h1:Kd8fb6EshOHXNNRtYAmLAwy/PotlyFoN0iMbuwGNh0M=
github.com/bufbuild/protocompile v0.7.1/go.mod h1:+Etjg4guZoAqzVk2czwEQP12yaxLJ8DxuqCJ9qHdH94=
github.com/bufbuild/protocompile v0.8.0 h1:9Kp1q6OkS9L4nM3FYbr8vlJnEwtbpDPQlQOVXfR+78s=
github.com/bufbuild/protocompile v0.8.0/go.mod h1:+Etjg4guZoAqzVk2czwEQP12yaxLJ8DxuqCJ9qHdH94=
github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c=
github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
github.com/google/go-cmp v0.6.0 h1:ofyhxvXcZhMsU5ulbFiLKl/XBFqE1GSq7atu8tAmTRI=
Expand Down

0 comments on commit 4b59272

Please sign in to comment.