fix ts error for profile page

buggregator · Sep 21, 2024 · 8d26048 · 8d26048
1 parent 17fa56f
commit 8d26048
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 11 deletions.
diff --git a/src/entities/profiler/lib/use-profiler/use-profiler.ts b/src/entities/profiler/lib/use-profiler/use-profiler.ts
@@ -7,7 +7,7 @@ type TUseProfiler = () => {
   normalizeProfilerEvent: (event: ServerEvent<Profiler>) => NormalizedEvent<Profiler>
   getTopFunctions: (id: EventId, params?: Record<string, string>) => Promise<ProfilerTopFunctions>
   getCallGraph: (id: EventId, params?: Record<string, string>) => Promise<ProfilerCallGraph>
-  getFlameChart: (id: EventId, params?: Record<string, string>) => Promise<ProfileFlameChart>
+  getFlameChart: (id: EventId, params?: Record<string, string>) => Promise<ProfileFlameChart[]>
 }
 
 export const useProfiler: TUseProfiler = () => {

diff --git a/src/entities/profiler/ui/flame-graph/flame-graph.vue b/src/entities/profiler/ui/flame-graph/flame-graph.vue
@@ -66,6 +66,7 @@ const renderChart = async () => {
   })
 
   flameChart.render()
+
   window.addEventListener(
     'resize',
     debounce(() => {

diff --git a/src/entities/profiler/ui/profiler-page/profiler-page.vue b/src/entities/profiler/ui/profiler-page/profiler-page.vue
@@ -43,16 +43,23 @@ const activeEdgeStyle = computed(() => {
   }
 })
 
+const clearActiveEdge = () => {
+  activeEdge.value = null
+  activeEdgePosition.value = defaultPosition
+}
+
 const setActiveEdge = (value: CallStackHoverData | undefined) => {
-  if (value) {
-    const { position, ...edge } = value || {}
-
-    activeEdge.value = edge
-    activeEdgePosition.value = position
-  } else {
-    activeEdge.value = null
-    activeEdgePosition.value = defaultPosition
+  if (!value) {
+    clearActiveEdge()
+    return
   }
+
+  const { position, ...edge } = value || {}
+
+  activeEdge.value = edge
+  activeEdgePosition.value = position
+
+  return
 }
 
 const tabChange = (selectedTab: { tab: { name: string } }) => {
@@ -82,7 +89,7 @@ const tabChange = (selectedTab: { tab: { name: string } }) => {
                 :data-key="activeTab"
                 :payload="event.payload"
                 @hover="setActiveEdge"
-                @hide="setActiveEdge"
+                @hide="clearActiveEdge"
               />
             </Tab>
 

diff --git a/src/shared/lib/io/use-profiler-requests.ts b/src/shared/lib/io/use-profiler-requests.ts
@@ -7,7 +7,7 @@ import { REST_API_URL } from "./constants";
 type TUseProfilerRequests = () => {
   getTopFunctions: (id: EventId, params?: Record<string, string>) => Promise<ProfilerTopFunctions>
   getCallGraph: (id: EventId, params?: Record<string, string>) => Promise<ProfilerCallGraph>
-  getFlameChart: (id: EventId) => Promise<ProfileFlameChart>
+  getFlameChart: (id: EventId) => Promise<ProfileFlameChart[]>
 }
 
 enum ProfilerPartType {