Fix warning when value not found by XPath

buggregator · May 1, 2024 · 9165cf3 · 9165cf3
1 parent 2060195
commit 9165cf3
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 4 deletions.
diff --git a/src/Service/Config/ConfigLoader.php b/src/Service/Config/ConfigLoader.php
@@ -59,7 +59,7 @@ private function injectValue(object $config, \ReflectionProperty $property, arra
 
                 /** @var mixed $value */
                 $value = match (true) {
-                    $attribute instanceof XPath => $this->xml?->xpath($attribute->path)[$attribute->key],
+                    $attribute instanceof XPath => @$this->xml?->xpath($attribute->path)[$attribute->key],
                     $attribute instanceof Env => $this->env[$attribute->name] ?? null,
                     $attribute instanceof InputOption => $this->inputOptions[$attribute->name] ?? null,
                     $attribute instanceof InputArgument => $this->inputArguments[$attribute->name] ?? null,

diff --git a/tests/Unit/Service/Config/ConfigLoaderTest.php b/tests/Unit/Service/Config/ConfigLoaderTest.php
@@ -25,8 +25,6 @@ public function testSimpleHydration(): void
             public string $myString;
             #[XPath('/trap/container/MyFloat/@value')]
             public float $myFloat;
-            #[XPath('/trap/container/Nothing/@value')]
-            public float $none = 3.14;
         };
         $xml = <<<'XML'
             <?xml version="1.0"?>
@@ -44,7 +42,31 @@ public function testSimpleHydration(): void
         self::assertSame(200, $dto->myInt);
         self::assertSame('foo-bar', $dto->myString);
         self::assertSame(42.0, $dto->myFloat);
-        self::assertSame(3.14, $dto->none);
+    }
+
+    public function testNonExistingOptions(): void
+    {
+        $dto = new class() {
+            #[XPath('/trap/container/Nothing/@value')]
+            public float $none1 = 3.14;
+            #[Env('f--o--o')]
+            public float $none2 = 3.14;
+            #[InputOption('f--o--o')]
+            public float $none3 = 3.14;
+            #[InputArgument('f--o--o')]
+            public float $none4 = 3.14;
+        };
+        $xml = <<<'XML'
+            <?xml version="1.0"?>
+            <trap my-string="foo-bar"> </trap>
+            XML;
+
+        $this->createConfigLoader(xml: $xml)->hidrate($dto);
+
+        self::assertSame(3.14, $dto->none1);
+        self::assertSame(3.14, $dto->none2);
+        self::assertSame(3.14, $dto->none3);
+        self::assertSame(3.14, $dto->none4);
     }
 
     public function testAttributesOrder(): void